-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating toObservable for Future #109
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d58d3b3
Creating toObservable for Future
abersnaze 24c0673
adding support for also get time outs.
abersnaze b276ae1
Merge commit 'b764ef1b1d76e8ecc9d7a826ee57023ea91c6327' into future
abersnaze 38ad57c
adding more details about how the toObservable behaves.
abersnaze File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
rxjava-core/src/main/java/rx/observables/operations/OperationToObservableFuture.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
package rx.observables.operations; | ||
|
||
import static org.mockito.Mockito.mock; | ||
import static org.mockito.Mockito.never; | ||
import static org.mockito.Mockito.times; | ||
import static org.mockito.Mockito.verify; | ||
import static org.mockito.Mockito.when; | ||
|
||
import java.util.concurrent.Future; | ||
|
||
import org.junit.Test; | ||
|
||
import rx.observables.Observable; | ||
import rx.observables.Observer; | ||
import rx.observables.Subscription; | ||
import rx.util.functions.Func1; | ||
|
||
public class OperationToObservableFuture { | ||
private static class ToObservableFuture<T> implements OperatorSubscribeFunction<T> { | ||
private final Future<T> that; | ||
|
||
public ToObservableFuture(Future<T> that) { | ||
this.that = that; | ||
} | ||
|
||
@Override | ||
public Subscription call(Observer<T> observer) { | ||
try { | ||
T value = that.get(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps we should add an overload that allows passing in the timeout values? |
||
if (!that.isCancelled()) { | ||
observer.onNext(value); | ||
} | ||
observer.onCompleted(); | ||
} catch (Exception e) { | ||
observer.onError(e); | ||
} | ||
|
||
// the get() has already completed so there is no point in | ||
// giving the user a way to cancel. | ||
return Observable.noOpSubscription(); | ||
} | ||
} | ||
|
||
public static <T> Func1<Observer<T>, Subscription> toObservableFuture(final Future<T> that) { | ||
return new ToObservableFuture<T>(that); | ||
} | ||
|
||
@SuppressWarnings("unchecked") | ||
public static class UnitTest { | ||
@Test | ||
public void testSuccess() throws Exception { | ||
Future<Object> future = mock(Future.class); | ||
Object value = new Object(); | ||
when(future.get()).thenReturn(value); | ||
ToObservableFuture ob = new ToObservableFuture(future); | ||
Observer<Object> o = mock(Observer.class); | ||
|
||
Subscription sub = ob.call(o); | ||
sub.unsubscribe(); | ||
|
||
verify(o, times(1)).onNext(value); | ||
verify(o, times(1)).onCompleted(); | ||
verify(o, never()).onError(null); | ||
verify(future, never()).cancel(true); | ||
} | ||
|
||
@Test | ||
public void testFailure() throws Exception { | ||
Future<Object> future = mock(Future.class); | ||
RuntimeException e = new RuntimeException(); | ||
when(future.get()).thenThrow(e); | ||
ToObservableFuture ob = new ToObservableFuture(future); | ||
Observer<Object> o = mock(Observer.class); | ||
|
||
Subscription sub = ob.call(o); | ||
sub.unsubscribe(); | ||
|
||
verify(o, never()).onNext(null); | ||
verify(o, never()).onCompleted(); | ||
verify(o, times(1)).onError(e); | ||
verify(future, never()).cancel(true); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overload with:
public static Observable toObservable(Future future, long timeout, TimeUnit unit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new method added