Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The privacy policy needs a scroll bar when it doesn't fit on screen, and the analytics opt out buttons becomes inaccessible #352

Closed
joanise opened this issue Oct 17, 2024 · 0 comments · Fixed by #359

Comments

@joanise
Copy link
Member

joanise commented Oct 17, 2024

On small screens, the policy privacy gets too long to fully display, and there is no scroll bar so you cannot access the Analytics Opt Out / Opt In button at all.

If you try to scroll, the app in the background behind the policy scrolls, but not the policy itself.

joanise added a commit that referenced this issue Oct 18, 2024
With a maxHeight of 95vh, we now automatically get a scroll bar if
needed, and the Opt out of/in to analytics button is always visible.

Also up the width from 50vw to 60vw, which again is nicer on screens
smaller than large monitors.

Fixes #352
joanise added a commit that referenced this issue Oct 21, 2024
* fix: make the privacy dialogue fully visible on smaller screens

With a maxHeight of 95vh, we now automatically get a scroll bar if
needed, and the Opt out of/in to analytics button is always visible.

Also up the width from 50vw to 60vw, which again is nicer on screens
smaller than large monitors.

Fixes #352

* chore: update translation IDs due to minor reformatting

* fix: add a 1em marging above the opt in button for better appearance

Based on Del's PR review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant