fix: make the privacy dialogue fully visible on smaller screens #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a maxHeight of 95vh, we now automatically get a scroll bar if needed, and the Opt out of/in to analytics button is always visible. Also up the width from 50vw to 60vw, which again is nicer on screens smaller than large monitors. Fixes #352
|
Review changes with SemanticDiff. Analyzed 5 of 5 files. Overall, the semantic diff is 81% smaller than the GitHub diff.
|
|
roedoejet
approved these changes
Oct 18, 2024
deltork
approved these changes
Oct 21, 2024
| >demonstration site here</a | ||
| >. In any case, you can opt out entirely by clicking the "Opt Out" button | ||
| below (you can always opt back in later). | ||
| </p> | ||
| </div> | ||
|
|
||
| <div mat-dialog-actions style="display: flex; justify-content: space-evenly"> |
There was a problem hiding this comment.
Should we add margin-top: 1em; to add more space between the text and buttons?
There was a problem hiding this comment.
Although I'm not sure which element that would belong on...
Based on Del's PR review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a maxHeight of 95vh, we now automatically get a scroll bar if needed, and the Opt out of/in to analytics button is always visible.
Also up the width from 50vw to 60vw, which again is nicer on screens smaller than large monitors.
PR Goal?
Make the Opt out of / in to analytics button visible on smaller screens, and add a scroll bar so the whole policy can be read on them.
Fixes?
Fixes #352
Feedback sought?
sanity checking, more or less just rubber stamping for this one
Priority?
medium-high
Tests added?
no
How to test?
click on Privacy and shrink your viewport to see the Opt in/out button is still usable and the full text can still be accessed.
Confidence?
high
Version change?
no