Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docer for ROSE #427

Open
AnnaDinaburgVulikh opened this issue Apr 28, 2021 · 4 comments
Open

Docer for ROSE #427

AnnaDinaburgVulikh opened this issue Apr 28, 2021 · 4 comments
Assignees
@sleviim

Comments

@AnnaDinaburgVulikh
Copy link
Contributor

Hello,
While trying to resolve #173 , encountered a problem with installing the DEV dependencies on Docker.
Here is the conflict:
image
@AnnaDinaburgVulikh AnnaDinaburgVulikh mentioned this issue Apr 28, 2021
Merged
@sleviim
Copy link
Member

sleviim commented May 3, 2021

@nirs @rollandf
Do you have any inssights about that one?

@AnnaDinaburgVulikh
Copy link
Contributor Author

@nirs @rollandf
Since the requirements.txt is generated from the pipfile, tried specifing the needed version in the pipfile, it didn't work.
Writing a designated requirements.txt with the needed version of idna worked.
The simple solution, as I see it, is generating a specific requirements file for DEV and setting the idna to the correct version. Should I set a specific version for other dependencies as pytest or just for idna?
Or maybe am I missing another solution?

@sleviim sleviim assigned sleviim and unassigned sleviim Jun 22, 2021
@sleviim
Copy link
Member

sleviim commented Jun 22, 2021

@nirs can you please share your thoughts on this one?

AnnaDinaburgVulikh added a commit to AnnaDinaburgVulikh/ROSE that referenced this issue Jul 7, 2021
@AnnaDinaburgVulikh
fixes dev docker RedHat-Israel#427
afb6cfc
sleviim pushed a commit that referenced this issue Jul 19, 2021
@AnnaDinaburgVulikh @sleviim
fixes dev docker #427
16552c7
@nirs
Copy link
Member

nirs commented Jul 15, 2022

We don't need pipenv to create a container. A container can replace pipenv completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleviim sleviim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nirs @sleviim @AnnaDinaburgVulikh