Dockerfile for ROSE #428
Merged
Dockerfile for ROSE #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RedHat-Israel#173 Uses official CentOS Python 2.7 image.
sleviim
reviewed
May 2, 2021
Dockerfile
Outdated
| @@ -0,0 +1,26 @@ | |||
| # Use official CentOS Python 2.7 image | |||
There was a problem hiding this comment.
@rollandf , shoulds we use python 3.6 for it?
There was a problem hiding this comment.
Python 2.7 is not supported, so yes.
There was a problem hiding this comment.
Hi, i'm not sure where you see this line.
In the files I commited the dicker uses python 3.7
There was a problem hiding this comment.
Maybe after rebasing it will be removed.
You can see another reference at line 3.
sleviim
requested changes
May 3, 2021
| ## Running a driver | ||
|
|
||
| In a new window, open your virtual environment: | ||
|
|
||
| pipenv shell | ||
|
|
||
| Create your driver file: | ||
|
|
||
| Create your driver file: |
There was a problem hiding this comment.
redundent space attheend of the line
sleviim
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sleviim @sfishbai ,
This pr is trying to follow the notes for #309 and raised the issue #427 .
One way of solving the issue is creating a requirements_dev.txt with the needed dependencies.
The question is, would you prefer to lock all the module versions or only
idna(the conflicting one)?