Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROSE Server in a Docker Container #309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ecliptik
Copy link
Contributor

@ecliptik ecliptik commented Oct 2, 2018

Fixes #173

Uses official CentOS Python 2.7 image.

Verified building and running locally and can access ROSE Server on http://locahlost:8880

Fixes RedHat-Israel#173

Uses official CentOS Python 2.7 image.
@rollandf rollandf requested a review from nirs October 3, 2018 05:51
ENABLE_PIPENV=true

# Install pipenv
RUN pip install --upgrade pipenv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we used a container, we don't need pipenv.


# Required env vars
ENV LD_LIBRARY_PATH="/opt/rh/python27/root/usr/lib64/" \
ENABLE_PIPENV=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need LD_LIBRARY_PATH?

COPY . ./

# Install dependencies from pipfile
RUN pipenv install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can install the requirements manually, or using a requirements.txt file generated
by pipenv.


# Server command
ENTRYPOINT [ "pipenv" ]
CMD [ "run", "python", "rose-server"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And without pipeenv, we can just run rose-server here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants