forked from 3scale/APIcast
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync fork with upstream #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog v3.13.0
…ms to be verified
…ssuer-verification THREESCALE-9009 fix OIDC jwt key verification
THREESCALE-7735 THREESCALE-8865 opentelemetry instrumentation
changelog v3.13.2
Currently, when key is base64 encoded or contains special chars, the batcher policy will save it to the cache but won't be able to retrieve it due to the regrex mismatch. This leads to two problems: * Reports are not sent to the backend * Report cache filling up over time. This commit changes the regular expression key to accept any character except spaces.
Previously when we changed penlight version we also removed the code to silent writing to global variables warning which was added in 3scale@d8bfb0c This commit has re-added the code to disable the warning again.
…olicy-storage [THREESCALE-9537] Configure batcher policy storage
…regrex [THREESCALE-10934] [3scale_batcher] Update regex to match key with special chars
Disable _G write guard warning
release 3.15.0
[chore] Remove unused shared dict
[3scale_batcher] Update regrex to match app_id with special characters
dagbay-rh
requested review from
coderbydesign,
abaiken,
casey-williams-rh and
petracihalova
May 2, 2024 18:24
petracihalova
approved these changes
May 13, 2024
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr_check
I added a
pr_check.sh
to build our images in prs to make sure they build oklinking file here since the diff is so huge: https://github.com/RedHatInsights/APIcast/pull/11/files#diff-46233f36c38a197d402638dc37fffcc351a00cd8d359b9de2c3923ae63008c4c
Testing