-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): sw-2353 activate json export for products #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1328 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 114 114
Lines 4526 4526
Branches 1911 1913 +2
=======================================
Hits 4164 4164
Misses 340 340
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
May 31, 2024
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
May 31, 2024
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
May 31, 2024
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
May 31, 2024
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 3, 2024
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 3, 2024
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 12, 2024
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 12, 2024
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 12, 2024
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 12, 2024
cdcabrera
force-pushed
the
sw-2353
branch
2 times, most recently
from
June 12, 2024 19:25
6c44496
to
23c8724
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 12, 2024
cdcabrera
force-pushed
the
sw-2353
branch
3 times, most recently
from
June 12, 2024 19:39
06b22d7
to
2c837ae
Compare
cdcabrera
force-pushed
the
sw-2353
branch
4 times, most recently
from
June 20, 2024 20:58
5f9465c
to
7aa020b
Compare
cdcabrera
commented
Jun 21, 2024
cdcabrera
force-pushed
the
sw-2353
branch
2 times, most recently
from
June 22, 2024 07:13
1b5102c
to
ecada2b
Compare
cdcabrera
force-pushed
the
sw-2353
branch
2 times, most recently
from
June 22, 2024 21:17
b67a8e1
to
05f2c71
Compare
This was referenced Jun 23, 2024
cdcabrera
force-pushed
the
main
branch
2 times, most recently
from
June 26, 2024 14:55
e12bf39
to
6fc1082
Compare
cdcabrera
force-pushed
the
sw-2353
branch
2 times, most recently
from
June 26, 2024 18:55
ff267bd
to
1bc0a63
Compare
cdcabrera
added a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
returning user
download behavioryes
andno
yes
will resume the downloadno
will perform a clean up action so the notification no longer appears on user returnHow to test
Coverage and basic unit test check
$ npm install
$ npm test
Proxy run check
$ npm install
$ npm run start:proxy
Check the build
$ npm install
$ npm run build
Example
Basic download behavior
Basic existing downloads behavior
Updates issue/story
sw-2353