Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): sw-2353 activate json export for products #1328

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented May 22, 2024

What's included

  • feat(config): sw-2353 activate json export for products
  • test: redux createStore import

Notes

  • this pr activates the toolbar export field
  • adjusts the original polling implementation to allow for 2 paths to attaining downloads
    • post -> poll general status for specific export until complete -> download report -> delete report for clean up
    • on UI load (user return) -> poll general status for ANY remaining exports until complete -> download ALL available reports -> delete ALL remaining reports for clean up
  • filenames of downloaded reports, we ended up using the internal product identifier because it was shorter
    • originally we had thought to use the short product display name for the report download name since it would be easier to identify to an end-user. unfortunately because some of the display names we use are "excessive" this ended up being awkward, for example...
      Screenshot 2024-06-26 at 4 23 26 PM
  • returning user download behavior
    • if a user does anything to interrupt the UI, like hit browser refresh, or navigate away from the UI, the download service continues working in the background
    • when the user returns a notification is displayed confirming if the user wants to continue the process, yes and no
    • hitting yes will resume the download
    • hitting no will perform a clean up action so the notification no longer appears on user return

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ npm install
  2. make sure you're on network, then
  3. $ npm run start:proxy
  4. navigate towards any product display
    • hit the download JSON menu option, confirm the file downloads

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

Basic download behavior

Jun-26-2024 16-31-39

Basic existing downloads behavior

Jun-26-2024 16-25-28

Updates issue/story

sw-2353

@cdcabrera cdcabrera added the 202408 project phase label May 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (030eada) to head (ff267bd).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1328   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files         114      114           
  Lines        4526     4526           
  Branches     1911     1913    +2     
=======================================
  Hits         4164     4164           
  Misses        340      340           
  Partials       22       22           
Files Coverage Δ
src/config/product.openshiftContainer.js 76.36% <ø> (ø)
src/config/product.openshiftDedicated.js 84.48% <ø> (ø)
src/config/product.openshiftMetrics.js 84.90% <ø> (ø)
src/config/product.rhacs.js 86.00% <ø> (ø)
src/config/product.rhel.js 78.72% <ø> (ø)
src/config/product.rhelElsPayg.js 77.35% <ø> (ø)
src/config/product.rhods.js 85.71% <ø> (ø)
src/config/product.rosa.js 80.76% <ø> (ø)
src/config/product.satellite.js 82.85% <ø> (ø)
src/redux/hooks/useReactRedux.js 93.54% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 030eada...ff267bd. Read the comment docs.

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request May 31, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request May 31, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request May 31, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request May 31, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 3, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 3, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 12, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 12, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 12, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 12, 2024
@cdcabrera cdcabrera force-pushed the sw-2353 branch 2 times, most recently from 6c44496 to 23c8724 Compare June 12, 2024 19:25
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 12, 2024
@cdcabrera cdcabrera force-pushed the sw-2353 branch 3 times, most recently from 06b22d7 to 2c837ae Compare June 12, 2024 19:39
@cdcabrera cdcabrera force-pushed the sw-2353 branch 4 times, most recently from 5f9465c to 7aa020b Compare June 20, 2024 20:58
.env Outdated Show resolved Hide resolved
src/redux/actions/platformActions.js Outdated Show resolved Hide resolved
src/redux/types/index.js Outdated Show resolved Hide resolved
src/services/common/serviceConfig.js Outdated Show resolved Hide resolved
src/components/toolbar/toolbarFieldExport.js Outdated Show resolved Hide resolved
@cdcabrera cdcabrera force-pushed the sw-2353 branch 2 times, most recently from 1b5102c to ecada2b Compare June 22, 2024 07:13
@cdcabrera cdcabrera marked this pull request as ready for review June 22, 2024 07:24
@cdcabrera cdcabrera force-pushed the sw-2353 branch 2 times, most recently from b67a8e1 to 05f2c71 Compare June 22, 2024 21:17
@cdcabrera cdcabrera force-pushed the main branch 2 times, most recently from e12bf39 to 6fc1082 Compare June 26, 2024 14:55
@cdcabrera cdcabrera force-pushed the sw-2353 branch 2 times, most recently from ff267bd to 1bc0a63 Compare June 26, 2024 18:55
@cdcabrera cdcabrera merged commit 1c75ef2 into RedHatInsights:main Jun 26, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202408 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants