-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(toolbarFieldExport): sw-2353 move notifications to hooks #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1343 +/- ##
==========================================
- Coverage 92.00% 92.00% -0.01%
==========================================
Files 113 114 +1
Lines 4401 4526 +125
Branches 1858 1911 +53
==========================================
+ Hits 4049 4164 +115
- Misses 332 340 +8
- Partials 20 22 +2
Continue to review full report in Codecov by Sentry.
|
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 23, 2024
…ghts#1343) * retryCount starts earlier, allow additional status callback firing * allow poll location urls to also include service call configs
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 23, 2024
a66f939
to
1d827b4
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 24, 2024
…ghts#1343) * retryCount starts earlier, allow additional status callback firing * allow poll location urls to also include service call configs
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 24, 2024
1d827b4
to
be3e2e2
Compare
be3e2e2
to
84a9467
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 24, 2024
…ghts#1343) * retryCount starts earlier, allow additional status callback firing * allow poll location urls to also include service call configs
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 24, 2024
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 26, 2024
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Jun 26, 2024
84a9467
to
bff9914
Compare
…tInsights#1343) * retryCount starts earlier, allow additional status callback firing * allow poll location urls to also include service call configs
…dHatInsights#1343) * dotenv, helpers, expose export configuration * locales, notification strings * toolbarFieldExport, move hooks to context helper * toolbarFieldExportContext, services and notification hooks * toolbarFieldSelectCategory, allow toolbar product config * platformActions, move notifications to hooks * appReducer, types, generic redux action for status * platformConstants, fix complete status * platformServices, polling, delete, download as packaged calls * platformTransformers, package logic to avoid in components
bff9914
to
973976c
Compare
cdcabrera
added a commit
that referenced
this pull request
Jun 26, 2024
* retryCount starts earlier, allow additional status callback firing * allow poll location urls to also include service call configs
cdcabrera
added a commit
that referenced
this pull request
Jul 16, 2024
* retryCount starts earlier, allow additional status callback firing * allow poll location urls to also include service call configs
cdcabrera
added a commit
that referenced
this pull request
Jul 16, 2024
) * dotenv, helpers, expose export configuration * locales, notification strings * toolbarFieldExport, move hooks to context helper * toolbarFieldExportContext, services and notification hooks * toolbarFieldSelectCategory, allow toolbar product config * platformActions, move notifications to hooks * appReducer, types, generic redux action for status * platformConstants, fix complete status * platformServices, polling, delete, download as packaged calls * platformTransformers, package logic to avoid in components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Coverage and basic unit test check
$ npm install
$ npm test
Check the build
$ npm install
$ npm run build
Example
...
Updates issue/story
related sw-2353 #1328 #1342