Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(toolbarFieldExport): sw-2353 move notifications to hooks #1343

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jun 23, 2024

What's included

  • refactor(toolbarFieldExport): sw-2353 move notifications to hooks
  • refactor(serviceConfig): sw-2353 start retryCount earlier

Notes

  • refactor prep for feat(config): sw-2353 activate json export for products #1328
  • no visual updates are directly accessible by end-user with this set of updates
  • during testing the default toast notifications highlighted some issues in the way platform level notifications are removed and added. this means we had to carefully time the notification removal to avoid throwing errors and creating duplicate notifications, and we had to remove "removal" of some notifications in favor of having them timeout. our solution is not necessarily ideal, but it does appear to work around the awkward lifecycle notifications have.

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

...

Updates issue/story

related sw-2353 #1328 #1342

@cdcabrera cdcabrera added the 202408 project phase label Jun 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 92.52336% with 16 lines in your changes missing coverage. Please review.

Project coverage is 92.00%. Comparing base (6fc1082) to head (973976c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1343      +/-   ##
==========================================
- Coverage   92.00%   92.00%   -0.01%     
==========================================
  Files         113      114       +1     
  Lines        4401     4526     +125     
  Branches     1858     1911      +53     
==========================================
+ Hits         4049     4164     +115     
- Misses        332      340       +8     
- Partials       20       22       +2     
Files Coverage Δ
src/common/helpers.js 100.00% <100.00%> (ø)
src/components/productView/productViewContext.js 96.34% <100.00%> (+0.34%) ⬆️
src/components/toolbar/toolbarFieldExport.js 96.55% <100.00%> (-0.60%) ⬇️
src/redux/reducers/appReducer.js 100.00% <100.00%> (ø)
src/redux/types/index.js 100.00% <ø> (ø)
src/services/common/serviceConfig.js 99.30% <100.00%> (+0.08%) ⬆️
src/services/platform/platformConstants.js 100.00% <100.00%> (ø)
src/redux/actions/platformActions.js 95.83% <94.44%> (-4.17%) ⬇️
...c/components/toolbar/toolbarFieldSelectCategory.js 72.22% <0.00%> (-2.78%) ⬇️
src/services/platform/platformTransformers.js 93.82% <87.50%> (+3.05%) ⬆️
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fc1082...973976c. Read the comment docs.

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 23, 2024
…ghts#1343)

* retryCount starts earlier, allow additional status callback firing
* allow poll location urls to also include service call configs
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 23, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 24, 2024
…ghts#1343)

* retryCount starts earlier, allow additional status callback firing
* allow poll location urls to also include service call configs
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 24, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 24, 2024
…ghts#1343)

* retryCount starts earlier, allow additional status callback firing
* allow poll location urls to also include service call configs
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 24, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 26, 2024
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 26, 2024
…tInsights#1343)

* retryCount starts earlier, allow additional status callback firing
* allow poll location urls to also include service call configs
…dHatInsights#1343)

* dotenv, helpers, expose export configuration
* locales, notification strings
* toolbarFieldExport, move hooks to context helper
* toolbarFieldExportContext, services and notification hooks
* toolbarFieldSelectCategory, allow toolbar product config
* platformActions, move notifications to hooks
* appReducer, types, generic redux action for status
* platformConstants, fix complete status
* platformServices, polling, delete, download as packaged calls
* platformTransformers, package logic to avoid in components
@cdcabrera cdcabrera merged commit 030eada into RedHatInsights:main Jun 26, 2024
7 checks passed
cdcabrera added a commit that referenced this pull request Jun 26, 2024
* retryCount starts earlier, allow additional status callback firing
* allow poll location urls to also include service call configs
cdcabrera added a commit that referenced this pull request Jul 16, 2024
* retryCount starts earlier, allow additional status callback firing
* allow poll location urls to also include service call configs
cdcabrera added a commit that referenced this pull request Jul 16, 2024
)

* dotenv, helpers, expose export configuration
* locales, notification strings
* toolbarFieldExport, move hooks to context helper
* toolbarFieldExportContext, services and notification hooks
* toolbarFieldSelectCategory, allow toolbar product config
* platformActions, move notifications to hooks
* appReducer, types, generic redux action for status
* platformConstants, fix complete status
* platformServices, polling, delete, download as packaged calls
* platformTransformers, package logic to avoid in components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202408 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants