Use version from report as output message version #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epapbak
force-pushed
the
CCXDEV-12869
branch
2 times, most recently
from
ae918d2 to
2cd3d8d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 85.77% 85.77%
=======================================
Files 28 28
Lines 1181 1181
=======================================
Hits 1013 1013
Misses 168 168 ☔ View full report in Codecov by Sentry. |
|
/retest |
|
/retest |
epapbak
requested review from
Bee-lee,
joselsegura,
matysek,
JiriPapousek,
juandspy and
Jakub007d
as code owners
JiriPapousek
approved these changes
May 29, 2024
epapbak
commented
May 29, 2024
joselsegura
requested changes
May 29, 2024
joselsegura
approved these changes
May 29, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use proper value for "version" field, now that it is included in the generated report. This also allows us to keep sending the same message as before (we keep alll the existing contracts and don't mess with the internals of our pipeline), instead of sending the report with the new "version" field included in the new format.
If the received report does not include the version field (always expected), the output message's version will be 0, causing the aggregator to warn about improper message version.
Fixes CCXDEV-12869
Type of change
Testing steps
CI
Checklist
pre-commit run -apasses