Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCXDEV-12924] Insert correct version in dvo_metrics_publisher output #243

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

epapbak
Copy link
Collaborator

@epapbak epapbak commented Jul 23, 2024

Description

Similar to #227, but for dvo_writer.
Skipping refactoring common code as that will take way more time...

Fixes CCXDEV-12924

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing steps

CI

Checklist

  • pre-commit run -a passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.78%. Comparing base (2308402) to head (5e6a942).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   85.77%   85.78%   +0.01%     
==========================================
  Files          28       28              
  Lines        1181     1182       +1     
==========================================
+ Hits         1013     1014       +1     
  Misses        168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epapbak epapbak marked this pull request as ready for review July 24, 2024 15:27
@epapbak epapbak changed the title Insert correct version in dvo_metrics_publisher output [CCXDEV-12924] Insert correct version in dvo_metrics_publisher output Jul 24, 2024
@epapbak epapbak enabled auto-merge (rebase) July 24, 2024 15:30
@epapbak epapbak merged commit 0e37066 into RedHatInsights:main Jul 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants