RHINENG-2450 Remove logic about the old SAP-related fields #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strider
force-pushed
the
RHINENG-2286
branch
5 times, most recently
from
d19719c to
c7a2a33
Compare
|
Hi @r14chandra @kgaikwad, Please, do you mind take a look at this PR when you have a cycle? Thanks, Gaël. |
strider
force-pushed
the
RHINENG-2286
branch
from
c7a2a33 to
9176d0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old SAP-related fields[1] will be removed in favor of the "sap" object[2]. Thus, this PR addresses RHINENG-2450.
For information, the pull request removing these old fields is [3][RHINENG-2286].
[1] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L511-L534
[2] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L483-L510
[3] - RedHatInsights/inventory-schemas#119