[DNM] RHINENG-2286: Remove standalone SAP-related fields #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are the System Profile validation results using Prod data. Validating against this PR's spec: |
|
Here are the System Profile validation results using Prod data. Validating against this PR's spec: |
|
Here are the System Profile validation results using Prod data. Validating against this PR's spec: |
strider
added a commit
to strider/insights-puptoo
that referenced
this pull request
Oct 10, 2023
The old SAP-related fields[1] will be removed in favor of the "sap" object[2]. Thus, this PR addresses RHINENG-2450. For information, the pull request removing these old fields is [3][RHINENG-2286]. [1] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L511-L534 [2] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L483-L510 [3] - RedHatInsights/inventory-schemas#119 Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
|
Here are the System Profile validation results using Prod data. Validating against this PR's spec: |
strider
added a commit
to strider/insights-puptoo
that referenced
this pull request
Oct 10, 2023
The old SAP-related fields[1] will be removed in favor of the "sap" object[2]. Thus, this PR addresses RHINENG-2450. For information, the pull request removing these old fields is [3][RHINENG-2286]. [1] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L511-L534 [2] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L483-L510 [3] - RedHatInsights/inventory-schemas#119 Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
strider
added a commit
to strider/insights-puptoo
that referenced
this pull request
Oct 10, 2023
The old SAP-related fields[1] will be removed in favor of the "sap" object[2]. Thus, this PR addresses RHINENG-2450. For information, the pull request removing these old fields is [3][RHINENG-2286]. [1] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L511-L534 [2] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L483-L510 [3] - RedHatInsights/inventory-schemas#119 Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
|
Here are the System Profile validation results using Prod data. Validating against this PR's spec: |
|
Here are the System Profile validation results using Prod data. Validating against this PR's spec: |
strider
added a commit
to strider/insights-puptoo
that referenced
this pull request
Oct 17, 2023
The old SAP-related fields[1] will be removed in favor of the "sap" object[2]. Thus, this PR addresses RHINENG-2450. For information, the pull request removing these old fields is [3][RHINENG-2286]. [1] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L511-L534 [2] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L483-L510 [3] - RedHatInsights/inventory-schemas#119 Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
strider
added a commit
to strider/insights-puptoo
that referenced
this pull request
Oct 17, 2023
The old SAP-related fields[1] will be removed in favor of the "sap" object[2]. Thus, this PR addresses RHINENG-2450. For information, the pull request removing these old fields is [3][RHINENG-2286]. [1] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L511-L534 [2] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L483-L510 [3] - RedHatInsights/inventory-schemas#119 Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
strider
added a commit
to strider/insights-puptoo
that referenced
this pull request
Oct 17, 2023
The old SAP-related fields[1] will be removed in favor of the "sap" object[2]. Thus, this PR addresses RHINENG-2450. For information, the pull request removing these old fields is [3][RHINENG-2286]. [1] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L511-L534 [2] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L483-L510 [3] - RedHatInsights/inventory-schemas#119 Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
|
@strider Purging of SAP fields may have to wait for sometime because I saw a message stating that frontend tests use SAP fields and its removal will cause a number of tests to fail. @karelhala had this comment https://issues.redhat.com/browse/RHINENG-2286?focusedId=23267610&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-23267610 |
strider
added a commit
to strider/insights-puptoo
that referenced
this pull request
Dec 11, 2023
The old SAP-related fields[1] will be removed in favor of the "sap" object[2]. Thus, this PR addresses RHINENG-2450. For information, the pull request removing these old fields is [3][RHINENG-2286]. [1] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L511-L534 [2] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L483-L510 [3] - RedHatInsights/inventory-schemas#119 Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
strider
force-pushed
the
RHINENG-2286
branch
from
0efefe2 to
1a46957
Compare
Do not merge this one until RHINENG-2450 (puptoo) is completed. Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
This change reverts the small change I've made in the initial commit in order to test the validations jobs trigger. Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
strider
force-pushed
the
RHINENG-2286
branch
from
1a46957 to
0f5c3f1
Compare
strider
added a commit
to strider/insights-puptoo
that referenced
this pull request
Dec 2, 2024
The old SAP-related fields[1] will be removed in favor of the "sap" object[2]. Thus, this PR addresses RHINENG-2450. For information, the pull request removing these old fields is [3][RHINENG-2286]. [1] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L511-L534 [2] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L483-L510 [3] - RedHatInsights/inventory-schemas#119 Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
JoySnow
pushed a commit
to RedHatInsights/insights-puptoo
that referenced
this pull request
Dec 3, 2024
The old SAP-related fields[1] will be removed in favor of the "sap" object[2]. Thus, this PR addresses RHINENG-2450. For information, the pull request removing these old fields is [3][RHINENG-2286]. [1] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L511-L534 [2] - https://github.com/RedHatInsights/inventory-schemas/blob/master/schemas/system_profile/v1.yaml#L483-L510 [3] - RedHatInsights/inventory-schemas#119 Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this one until RHINENG-2450 (puptoo) is completed.