Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance search feature to support path #2145

Merged
merged 8 commits into from
Sep 6, 2022
Merged

Conversation

bpateldx
Copy link
Contributor

@bpateldx bpateldx commented Aug 30, 2022

  • This allows easy and quick navigation for well-known end-points by path or keywords in a path
  • Supports existing search functionality

Testing

Added E2E Test for the change

Screenshots

image
image
Now search work for keywords in path:
image
Now search works for paths:
image
Current search still works:
image

Completed

  • [ x] Code is linted
  • [ x] Tested
  • [ x] All new/updated code is covered with (E2E) tests

@bpateldx bpateldx requested a review from a team as a code owner August 30, 2022 14:30
@bpateldx bpateldx requested review from AlexVarchuk and removed request for a team August 30, 2022 14:30
CHANGELOG.md Outdated Show resolved Hide resolved
@AlexVarchuk
Copy link
Collaborator

Hi @bpateldx, thank you for your contribution. Please, add some screenshots of how the search is working now. Thanks.

@bpateldx bpateldx requested a review from AlexVarchuk August 30, 2022 14:57
@bpateldx
Copy link
Contributor Author

@AlexVarchuk Thank you for your feedback on reviews. What's ETA/process on merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants