Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tests for cover field default #2389

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

AlexVarchuk
Copy link
Collaborator

@AlexVarchuk AlexVarchuk commented Aug 18, 2023

What/Why/How?

add more tests to prevent feature problems with field->default value.

Reference

Original related issue: #2385
Fixed PR: #2386

Tests

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

@AlexVarchuk AlexVarchuk self-assigned this Aug 18, 2023
@AlexVarchuk AlexVarchuk requested a review from a team as a code owner August 18, 2023 16:29
Copy link
Member

@adamaltman adamaltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is incomplete. It needs to reference the original issue and the PR that fixed it.

@lornajane lornajane dismissed adamaltman’s stale review August 21, 2023 07:44

The PR has the relevant information in it, as requested.

@AlexVarchuk AlexVarchuk merged commit 2eff85a into main Aug 31, 2023
6 checks passed
@AlexVarchuk AlexVarchuk deleted the chore/tests-for-cover-default-field-value branch August 31, 2023 07:43
ckoegel pushed a commit to Bandwidth/redoc that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants