Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building for Windows ARM64 platforms #17

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

anthony-linaro
Copy link
Contributor

@anthony-linaro anthony-linaro commented Sep 11, 2024

This only works when using clang-cl as the compiler, as that is the only compiler that works with embree on Windows ARM64 platforms.

Using LLVM 18.1.8

Tested with the following command line (using the copy of TBB produced as part of a Blender deps build, with the changes described here applied: uxlfoundation/oneTBB#1142):

cmake -G Ninja -DCMAKE_INSTALL_PREFIX=<install prefix> -DOPENPGL_TBB_ROOT=<tbb 2020u3 root from blender deps build> -DOpenImageDenoise_DIR=<path to OIDN from blender deps build> -DCMAKE_C_COMPILER="C:/Program Files/LLVM/bin/clang-cl.exe" -DCMAKE_CXX_COMPILER="C:/Program Files/LLVM/bin/clang-cl.exe" ..

All builds fine, and it appears to be working correctly in blender.

@anthony-linaro anthony-linaro changed the base branch from main to devel September 11, 2024 10:45
@sherholz-intel
Copy link
Collaborator

@anthony-linaro thanks for the PR.
Could you do me a favor and change the commit messages.
Our style is to start with a label [..] in your case it would be [sse2neon].
Could you also add in the first commit the info to which version of sse2neon you updated?
Thanks.

@anthony-linaro
Copy link
Contributor Author

@sherholz-intel All done, I added sse2neon for the specific sse2neon commit, and sse2neon+compile for the other one, as it touched more than just sse2neon

@sherholz-intel sherholz-intel merged commit a48b4bc into RenderKit:devel Sep 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants