Move TODOs into GitHub

part of #597
RevenueCat · Aug 25, 2021 · bdd3390 · bdd3390
1 parent 3541071
commit bdd3390
Show file tree

Hide file tree

Showing 10 changed files with 5 additions and 32 deletions.
diff --git a/PublicSDKAPITester/RCPurchasesAPI.m b/PublicSDKAPITester/RCPurchasesAPI.m
@@ -30,15 +30,6 @@ @implementation RCPurchasesAPI
 BOOL isAnonymous;
 
 + (void)checkAPI {
-    // TODO: Addresses these blocks
-    // typedef void (^RCReceivePurchaserInfoBlock)(RCPurchaserInfo * _Nullable, NSError * _Nullable) NS_SWIFT_NAME(Purchases.ReceivePurchaserInfoBlock);
-    // typedef void (^RCReceiveIntroEligibilityBlock)(NSDictionary<NSString *, RCIntroEligibility *> *) NS_SWIFT_NAME(Purchases.ReceiveIntroEligibilityBlock);
-    // typedef void (^RCReceiveOfferingsBlock)(RCOfferings * _Nullable, NSError * _Nullable) NS_SWIFT_NAME(Purchases.ReceiveOfferingsBlock);
-    // typedef void (^RCReceiveProductsBlock)(NSArray<SKProduct *> *) NS_SWIFT_NAME(Purchases.ReceiveProductsBlock);
-    // typedef void (^RCPurchaseCompletedBlock)(SKPaymentTransaction * _Nullable, RCPurchaserInfo * _Nullable, NSError * _Nullable, BOOL userCancelled) NS_SWIFT_NAME(Purchases.PurchaseCompletedBlock);
-    // typedef void (^RCDeferredPromotionalPurchaseBlock)(RCPurchaseCompletedBlock);
-    // typedef void (^RCPaymentDiscountBlock)(SKPaymentDiscount * _Nullable, NSError * _Nullable) NS_SWIFT_NAME(Purchases.PaymentDiscountBlock);
-
     // TODO: iOS ONLY, TEST FOR THIS API BY LOOKING UP SELECTOR
     // [p presentCodeRedemptionSheet];
     RCPurchases *p = [RCPurchases configureWithAPIKey:@""];

diff --git a/PurchasesCoreSwift/Attribution/AttributionPoster.swift b/PurchasesCoreSwift/Attribution/AttributionPoster.swift
@@ -58,8 +58,6 @@ class AttributionPoster {
             deviceCache.latestNetworkAndAdvertisingIdsSent(appUserID: currentAppUserID)
         let latestSentToNetwork = latestNetworkIdsAndAdvertisingIdsSentByNetwork[networkKey]
 
-        // TODO: `(null)` is true to the ObjC code here, maybe we should reject this and not post?
-        // Post-migration: early return here.
         let newValueForNetwork = "\(maybeIdentifierForAdvertisers ?? "(null)")_\(networkUserId ?? "(null)")"
         guard latestSentToNetwork != newValueForNetwork else {
             Logger.debug(Strings.attribution.skip_same_attributes)

diff --git a/PurchasesCoreSwift/Networking/Backend.swift b/PurchasesCoreSwift/Networking/Backend.swift
@@ -636,7 +636,6 @@ private extension Backend {
     func getOfferingsCallbacksAndClearCache(forKey key: String) -> [OfferingsResponseHandler] {
         return callbackQueue.sync { [self] in
             let callbacks = offeringsCallbacksCache.removeValue(forKey: key)
-            // TODO: Should we throw instead of NSParameterAssert?
             assert(callbacks != nil)
             return callbacks ?? []
         }
@@ -645,7 +644,6 @@ private extension Backend {
     func getPurchaserInfoCallbacksAndClearCache(forKey key: String) -> [BackendPurchaserInfoResponseHandler] {
         return callbackQueue.sync { [self] in
             let callbacks = purchaserInfoCallbacksCache.removeValue(forKey: key)
-            // TODO: Should we throw instead of NSParameterAssert?
             assert(callbacks != nil)
             return callbacks ?? []
         }

diff --git a/PurchasesCoreSwift/Public/EntitlementInfo.swift b/PurchasesCoreSwift/Public/EntitlementInfo.swift
@@ -134,7 +134,6 @@ import Foundation
                   dateFormatter: .iso8601SecondsDateFormatter)
     }
 
-    // TODO(cleanup): Codable
     init(entitlementId: String,
          entitlementData: [String: Any],
          productData: [String: Any],
@@ -285,7 +284,6 @@ private extension EntitlementInfo {
 
     class func parseOwnershipType(ownershipType: String?) -> PurchaseOwnershipType {
         guard let ownershipType = ownershipType else {
-            // TODO: should this be a warning?
             return .purchased
         }
 

diff --git a/PurchasesCoreSwift/Public/Offering.swift b/PurchasesCoreSwift/Public/Offering.swift
@@ -71,7 +71,6 @@ import Foundation
         self.serverDescription = serverDescription
         self.availablePackages = availablePackages
 
-        // TODO: add validation to ensure we don't get multiple packages with the same type
         for package in availablePackages {
             switch package.packageType {
             case .lifetime:

diff --git a/PurchasesCoreSwift/Public/PurchaserInfo.swift b/PurchasesCoreSwift/Public/PurchaserInfo.swift
@@ -145,11 +145,9 @@ import Foundation
             """
     }
 
-    // TODO after migration make this internal
-    @objc public let schemaVersion: String?
+    let schemaVersion: String?
 
-    // TODO after migration make this internal
-    @objc public convenience init?(data: [String: Any]) {
+    convenience init?(data: [String: Any]) {
         self.init(data: data, dateFormatter: .iso8601SecondsDateFormatter, transactionsFactory: TransactionsFactory())
     }
 
@@ -189,11 +187,9 @@ import Foundation
         self.allPurchases = subscriberData.allPurchases
     }
 
-    // TODO after migration make this internal
-    @objc public static let currentSchemaVersion = "2"
+    static let currentSchemaVersion = "2"
 
-    // TODO after migration make this internal and remove objc rename
-    @objc(JSONObject) public func jsonObject() -> [String: Any] {
+    func jsonObject() -> [String: Any] {
         return originalData.merging(
             ["schema_version": PurchaserInfo.currentSchemaVersion],
             strategy: .keepOriginalValue

diff --git a/PurchasesCoreSwift/Purchasing/ProductsRequestFactory.swift b/PurchasesCoreSwift/Purchasing/ProductsRequestFactory.swift
@@ -13,7 +13,6 @@
 import Foundation
 import StoreKit
 
-// todo: make internal
 class ProductsRequestFactory {
 
     func request(productIdentifiers: Set<String>) -> SKProductsRequest {

diff --git a/PurchasesCoreSwift/Purchasing/PurchasesOrchestrator.swift b/PurchasesCoreSwift/Purchasing/PurchasesOrchestrator.swift
@@ -131,8 +131,6 @@ class PurchasesOrchestrator {
                               receiptData: receiptData,
                               appUserID: self.appUserID) { maybeSignature, maybeKeyIdentifier, maybeNonce, maybeTimestamp, maybeError in
                 if let error = maybeError {
-                    // TODO: Consider making a custom error. issues/751
-                    // https://github.com/RevenueCat/purchases-ios/issues/751
                     completion(nil, error)
                     return
                 }
@@ -141,8 +139,6 @@ class PurchasesOrchestrator {
                       let nonce = maybeNonce,
                       let signature = maybeSignature,
                       let timestamp = maybeTimestamp else {
-                          // TODO: Consider making a custom error.
-                          // https://github.com/RevenueCat/purchases-ios/issues/751
                           completion(nil, ErrorUtils.unexpectedBackendResponseError())
                           return
                       }
@@ -225,7 +221,6 @@ extension PurchasesOrchestrator: StoreKitWrapperDelegate {
 
     func storeKitWrapper(_ storeKitWrapper: StoreKitWrapper,
                          removedTransaction transaction: SKPaymentTransaction) {
-        // todo: remove
         // unused for now
     }
 

diff --git a/PurchasesCoreSwift/Purchasing/StoreKitWrapper.swift b/PurchasesCoreSwift/Purchasing/StoreKitWrapper.swift
@@ -82,7 +82,7 @@ class StoreKitWrapper: NSObject, SKPaymentTransactionObserver {
 
     func payment(withProduct product: SKProduct) -> SKMutablePayment {
         let payment = SKMutablePayment(product: product)
-        // todo: check that it's fine to omit tvOS and iOS since the relevant methods exist in targets lower than ours
+
         if #available(macOS 10.14, watchOS 6.2, macCatalyst 13.0, *) {
             payment.simulatesAskToBuyInSandbox = Self.simulatesAskToBuyInSandbox
         }

diff --git a/PurchasesCoreSwiftTests/Purchasing/OfferingsManagerTests.swift b/PurchasesCoreSwiftTests/Purchasing/OfferingsManagerTests.swift
@@ -16,7 +16,6 @@ import Nimble
 import StoreKit
 @testable import PurchasesCoreSwift
 
-// TODO (post-migration): Move this test case to the new framework target (PurchasesCoreSwift).
 class OfferingsManagerTests: XCTestCase {
 
     let mockDeviceCache = MockDeviceCache()