Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable disabled Swiftlint rules after migration. #597

Closed
6 tasks done
taquitos opened this issue Jun 26, 2021 · 1 comment · Fixed by #782
Closed
6 tasks done

Enable disabled Swiftlint rules after migration. #597

taquitos opened this issue Jun 26, 2021 · 1 comment · Fixed by #782
Assignees
@taquitos
Labels
swift migration
Milestone
Swift Migration 🐦

Comments

@taquitos
Copy link
Contributor

taquitos commented Jun 26, 2021 •
edited
Loading

  • Clean up todos and turn into issues
  • todo rule
  • cyclomatic_complexity
  • function_body_length
  • identifier_name
  • line_length
@taquitos taquitos added this to the Swift Migration 🐦 milestone Jun 26, 2021
taquitos added a commit that referenced this issue Jun 26, 2021
@taquitos
Disable todo, cyclomatic_complexity, and function_body_length rule fo…
0948fca 
…r now.

- Issue #597 filed for when we should re-enable them.
taquitos added a commit that referenced this issue Jun 28, 2021
@taquitos
Migrates RCEntitlementInfo (#596)
db98a4a 
* Add support for RCEntitlementInfo API testing

* Migrates RCEntitlementInfo

* Added RCLogLevel check, moved EntitlementInfo enum tests into the API tester for EntitlementInfo

* Disable todo, cyclomatic_complexity, and function_body_length rule for now.
- Issue #597 filed for when we should re-enable them.

* Updated for comments

* Make some things private, and fix some indentation
@ghost ghost added the status: needs-additional-info Issues that are missing steps from bug template label Jun 29, 2021
@taquitos taquitos removed the status: needs-additional-info Issues that are missing steps from bug template label Jul 1, 2021
@taquitos taquitos self-assigned this Aug 24, 2021
taquitos added a commit that referenced this issue Aug 25, 2021
@taquitos
Move TODOs into GitHub
bdd3390 
part of #597
@taquitos taquitos mentioned this issue Aug 25, 2021
Merged
taquitos added a commit that referenced this issue Aug 25, 2021
@taquitos
Move TODOs into GitHub (#778)
7d1348e 
* Move TODOs into GitHub
part of #597

* Remove extra space

* add @testable import to two test suites

* Update for RCPurchaserInfo -init being unavailable
@taquitos taquitos mentioned this issue Aug 25, 2021
Merged
@taquitos taquitos linked a pull request Aug 25, 2021 that will close this issue
Enable swiftlint #782
Merged
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This issue has been automatically locked due to no recent activity after it was closed. Please open a new issue for related reports.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@taquitos taquitos

Labels
swift migration
Projects
None yet
Milestone
Swift Migration 🐦
Development

Successfully merging a pull request may close this issue.

Enable swiftlint RevenueCat/purchases-ios
1 participant
@taquitos