Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable swiftlint #782

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Enable swiftlint #782

merged 2 commits into from
Aug 25, 2021

Conversation

taquitos
Copy link
Contributor

@taquitos taquitos commented Aug 25, 2021

Enable swiftlint, fix all warnings.
Resolves #597

Created: #779, #780, #781 for the todos that were deleted.

Enable swiftlint, fix warnings.
@taquitos taquitos requested a review from a team August 25, 2021 18:23
@taquitos taquitos linked an issue Aug 25, 2021 that may be closed by this pull request
6 tasks
@@ -37,7 +37,6 @@ class FakeTrackingManager: NSObject {

}

// TODO: Test if Objc can be removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this tested?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, but I have #779, #780, #781 all ready to test each one 😄

PurchasesCoreSwift/Public/Purchases.swift Outdated Show resolved Hide resolved
Co-authored-by: Cesar de la Vega <cesarvegaro@gmail.com>
@taquitos taquitos requested a review from vegaro August 25, 2021 21:21
@taquitos taquitos merged commit 014bc07 into swift_migration Aug 25, 2021
@taquitos taquitos deleted the swift_lint_enable branch August 25, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable disabled Swiftlint rules after migration.
2 participants