SKError, StoreKitError, and Product.PurchaseError conform to ErrorCodeConvertible + tests
#1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
commented
Apr 8, 2022
Comment on lines
+94
to
+113
| func testCurrentlySubscribedError() throws { | ||
| let error = try XCTUnwrap( | ||
| NSError( | ||
| domain: SKErrorDomain, | ||
| code: SKError.unknown.rawValue, | ||
| userInfo: [ | ||
| NSUnderlyingErrorKey: NSError( | ||
| domain: "ASDServerErrorDomain", | ||
| code: 3532, | ||
| userInfo: [:] | ||
| ) | ||
| ] | ||
| ) as? SKError | ||
| ) | ||
|
|
||
| verifyPurchasesError(error, | ||
| expectedCode: .productAlreadyPurchasedError, | ||
| underlyingError: error) | ||
| } |
There was a problem hiding this comment.
These are much better to test this way instead of in PurchasesTests. Though I left the original tests too.
| @@ -15,9 +15,9 @@ import StoreKit | |||
|
|
|||
| /// - SeeAlso: SKError+Extensions | |||
| @available(iOS 15.0, tvOS 15.0, watchOS 8.0, macOS 12.0, *) | |||
| extension StoreKitError { | |||
| extension StoreKitError: ErrorCodeConvertible { | |||
There was a problem hiding this comment.
Now all our errors conform to this 🎉
NachoSoto
changed the title
SKError, StoreKitError, and Product.PurchaseError conform to ErrorCodeConvertible and added testsSKError, StoreKitError, and Product.PurchaseError conform to ErrorCodeConvertible + tests
NachoSoto
force-pushed
the
storekit-error-conversion-tests
branch
from
d65d66e
to
67c8f43
Compare
NachoSoto
force-pushed
the
storekit-error-conversion-tests
branch
from
67c8f43
to
3e4cb4c
Compare
NachoSoto
force-pushed
the
storekit-error-conversion-tests
branch
from
3e4cb4c
to
d124750
Compare
taquitos
reviewed
Apr 11, 2022
| underlyingError: error) | ||
| } | ||
|
|
||
| func testPaymentSheetCancelledError() throws { |
taquitos
reviewed
Apr 11, 2022
| ) as? SKError | ||
| ) | ||
|
|
||
| verifyPurchasesError(error, |
There was a problem hiding this comment.
This is so good that we have tests for this. I'm loving the new errors
There was a problem hiding this comment.
Yeah I'm using this new helper in all of these which makes it very simple :)
aboedo
approved these changes
Apr 11, 2022
NachoSoto
force-pushed
the
storekit-error-conversion-tests
branch
from
d124750
to
1930eb0
Compare
NachoSoto
force-pushed
the
storekit-error-conversion-tests
branch
from
1930eb0
to
2d129d0
Compare
…rrorCodeConvertible` and added tests Follow up to #1437. Fixes [CF-323]
NachoSoto
force-pushed
the
storekit-error-conversion-tests
branch
from
2d129d0
to
59422da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1437.
Fixes CF-323