Integration Tests
: simplified testIneligibleForIntroAfterPurchaseExpires
to fix flakiness
#1952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CSDK-479.
Changes:
verifyEntitlementWentThrough
.Integration Tests
: actually verify that entitlement is active #1880 introduced a change so that weekly subscriptions aren't verified, because they expire within a second. This make the test flaky due to that race condition.assertNoActiveSubscription
: I tried callingSKTestSession.disableAutoRenewForTransaction
, but sometimes the server still thinks the subscription has auto-renewed. This was making the test flaky. Turns out that even if it's not active, the eligibility test still passes as expected.syncPurchases
. It doesn't matter what state the server is in, as long as locallySKTestSession
has an expired subscription.This, together with #1945, should fix the last of the issues causing flaky integration tests 🤞🏻