-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AUTOMATIC] Release/4.13.2 #1980
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
force-pushed
the
release/4.13.2
branch
from
October 13, 2022 15:19
bb6a826
to
0aa88c5
Compare
FYI I'll be looking into the release failures and the iOS 12 issue today: CSDK-491 |
Due to same macOS SDK issue
Okay the last fix is the Catalyst build. |
NachoSoto
added a commit
that referenced
this pull request
Oct 14, 2022
I broke this in an earlier PR but we didn't notice because we don't compile that on every PR. I filed [TRIAGE-82] for that. This fixes the rest of the release checks in #1980.
Fixed Catalyst build: #1981 |
NachoSoto
added a commit
that referenced
this pull request
Oct 14, 2022
I broke this in an earlier PR but we didn't notice because we don't compile that on every PR. I filed [TRIAGE-82] for that. This fixes the rest of the release checks in #1980. [TRIAGE-82]: https://revenuecats.atlassian.net/browse/TRIAGE-82?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
I broke this in an earlier PR but we didn't notice because we don't compile that on every PR. I filed [TRIAGE-82] for that. This fixes the rest of the release checks in #1980. [TRIAGE-82]: https://revenuecats.atlassian.net/browse/TRIAGE-82?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Fixed iOS 12: #1982 |
NachoSoto
force-pushed
the
release/4.13.2
branch
from
October 14, 2022 20:33
0c90b1c
to
973a0c4
Compare
NachoSoto
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic release.
Bugfixes
ErrorUtils
: improved logging andlocalizedDescription
to include underlying errors (ErrorUtils
: improved logging andlocalizedDescription
to include underlying errors #1974) via NachoSoto (@NachoSoto)PaymentQueueWrapper
: also implementshouldShowPriceConsent
(PaymentQueueWrapper
: also implementshouldShowPriceConsent
#1963) via NachoSoto (@NachoSoto)ReceiptFetcher
: added retry mechanism (ReceiptFetcher
: added retry mechanism #1945) via NachoSoto (@NachoSoto)PaymentQueueWrapper
: also conform toSKPaymentTransactionObserver
to fix promoted purchases (PaymentQueueWrapper
: also conform toSKPaymentTransactionObserver
to fix promoted purchases #1962) via NachoSoto (@NachoSoto)Other Changes
OfferingsManager
: added ability to fail if any product is not found (OfferingsManager
: added ability to fail if any product is not found #1976) via NachoSoto (@NachoSoto)OfferingsManager
: added missing test for ignoring missing products (OfferingsManager
: added missing test for ignoring missing products #1975) via NachoSoto (@NachoSoto)PaymentQueueWrapper
: improved abstraction for activeSKPaymentQueue
wrapper (PaymentQueueWrapper
: improved abstraction for activeSKPaymentQueue
wrapper #1968) via NachoSoto (@NachoSoto)ErrorUtils.purchasesError(withUntypedError:)
handlePurchasesErrorConvertible
(ErrorUtils.purchasesError(withUntypedError:)
handlePurchasesErrorConvertible
#1973) via NachoSoto (@NachoSoto)CallbackCache.add(callback:)
(RenamedCallbackCache.add(callback:)
#1970) via NachoSoto (@NachoSoto)SKPaymentQueue.presentCodeRedemptionSheet
toStoreKitWorkarounds
(MovedSKPaymentQueue.presentCodeRedemptionSheet
toStoreKitWorkarounds
#1967) via NachoSoto (@NachoSoto)Async.call
method to convert completion-block call toasync
(Async.call
method to convert completion-block call toasync
#1969) via NachoSoto (@NachoSoto)PostReceiptDataOperation
: addedinitiationSource
parameter (PostReceiptDataOperation
: addedinitiationSource
parameter #1957) via NachoSoto (@NachoSoto)StoreKit1Wrapper
: separatedSKPaymentTransactionObserver
andSKPaymentQueueDelegate
implementations (StoreKit1Wrapper
: separatedSKPaymentTransactionObserver
andSKPaymentQueueDelegate
implementations #1961) via NachoSoto (@NachoSoto)Error.isCancelledError
intoError+Extensions
(RefactoredError.isCancelledError
intoError+Extensions
#1960) via NachoSoto (@NachoSoto)Integration Tests
: simplifiedtestIneligibleForIntroAfterPurchaseExpires
to fix flakiness (Integration Tests
: simplifiedtestIneligibleForIntroAfterPurchaseExpires
to fix flakiness #1952) via NachoSoto (@NachoSoto)