Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StoreKit1Wrapper: separated SKPaymentTransactionObserver and SKPaymentQueueDelegate implementations #1961

Merged
merged 2 commits into from
Oct 7, 2022
Merged

StoreKit1Wrapper: separated SKPaymentTransactionObserver and SKPaymentQueueDelegate implementations #1961

merged 2 commits into from
Oct 7, 2022

Conversation

NachoSoto
Copy link
Contributor

This way it's more clear which methods belong to which protocol.
This confusion is what lead to #1901 being wrong (will fix in a separate PR).

@NachoSoto NachoSoto requested a review from a team September 30, 2022 18:47
@NachoSoto
StoreKit1Wrapper: separated SKPaymentTransactionObserver and `SKP…
fa9bff5 
…aymentQueueDelegate` implementations

This way it's more clear which methods belong to which protocol.
This confusion is what lead to #1901 being wrong.
@NachoSoto NachoSoto mentioned this pull request Sep 30, 2022
Merged
NachoSoto added a commit that referenced this pull request Sep 30, 2022
@NachoSoto
PaymentQueueWrapper: also conform to SKPaymentTransactionObserver…
8e43fe8 
… to fix promoted purchases

Follow up to #1901. That fix was incomplete. I missed it because the protocols were mixed up (fixed in #1961).
Now `PaymentQueueWrapper`, when set up as the delegate (only when SK2 is enabled and SK1 is disabled) will be added as a transaction observer.
@NachoSoto NachoSoto merged commit 0dda9c4 into main Oct 7, 2022
@NachoSoto NachoSoto deleted the store-kit-wrapper-delegates branch October 7, 2022 14:31
NachoSoto added a commit that referenced this pull request Oct 7, 2022
@NachoSoto
PaymentQueueWrapper: also conform to SKPaymentTransactionObserver…
3ef87d2 
… to fix promoted purchases

Follow up to #1901. That fix was incomplete. I missed it because the protocols were mixed up (fixed in #1961).
Now `PaymentQueueWrapper`, when set up as the delegate (only when SK2 is enabled and SK1 is disabled) will be added as a transaction observer.
NachoSoto added a commit that referenced this pull request Oct 7, 2022
@NachoSoto
PaymentQueueWrapper: also conform to SKPaymentTransactionObserver…
7dd98ee 
… to fix promoted purchases (#1962)

Follow up to #1901. That fix was incomplete. I missed it because the
protocols were mixed up (fixed in #1961). Now `PaymentQueueWrapper`,
when set up as the delegate (only when SK2 is enabled and SK1 is
disabled) will be added as a transaction observer.
@revenuecat-ops revenuecat-ops mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegaro vegaro vegaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NachoSoto @vegaro