PostReceiptDataOperation: added initiationSource parameter
#1957
Conversation
NachoSoto
force-pushed
the
post-receipt-user-initiated
branch
3 times, most recently
from
d5f0a90
to
57e2e33
Compare
NachoSoto
changed the title
PostReceiptDataOperation: added userInitiated parameterPostReceiptDataOperation: added initationSource parameter
NachoSoto
changed the title
PostReceiptDataOperation: added initationSource parameterPostReceiptDataOperation: added initiationSource parameter
NachoSoto
force-pushed
the
post-receipt-user-initiated
branch
2 times, most recently
from
56088bc
to
e48708e
Compare
|
This is ready (just need to fix the snapshots). |
| @@ -20,6 +20,20 @@ import StoreKit | |||
| /// - SeeAlso: `Backend/post(receiptData:appUserID:isRestore:productData:...` | |||
| struct ProductRequestData { | |||
|
|
|||
| /// Determins what triggered a receipt to be posted | |||
| enum InitiationSource: CaseIterable { | |||
There was a problem hiding this comment.
Hmm what do you think about ReceiptPostSource? Feels like a better name to me but looks like renaming would require a backend change and I don't think it's a big deal.
There was a problem hiding this comment.
We don't have to match the backend, but I can see either way.
If we don't, we can have something more "Swifty", but I think the advantage of having this match the backend is familiarity, so this term is the same across different repos.
What do you think?
There was a problem hiding this comment.
Maybe another thing to realize is that this isn't just InitiationSource, it's namespaced as ProductRequestData.InitiationSource.
|
|
||
| // MARK: - InitiationSource | ||
|
|
||
| extension ProductRequestData.InitiationSource: Encodable, RawRepresentable { |
There was a problem hiding this comment.
Hmm I do wonder if this would be better placed in the ProductRequestData.swift file... If it's only needed from here, this would be ok though
There was a problem hiding this comment.
My goal with this is to keep the type definition simpler. This is more of an implementation detail of how the source is posted to the backend.
NachoSoto
force-pushed
the
post-receipt-user-initiated
branch
from
49c5f8b
to
e7843d2
Compare
…e transactions (#2430) All StoreKit 1 transactions were being sent with `InitiationSource.purchased`. #1957 introduced this, but it was only set correctly for SK2. The consequence of this is that users might see "invalid receipt" errors when posting receipts due to updated transactions from the queue, which can only happen for `InitiationSource.purchased`.
…e transactions (#2430) All StoreKit 1 transactions were being sent with `InitiationSource.purchased`. #1957 introduced this, but it was only set correctly for SK2. The consequence of this is that users might see "invalid receipt" errors when posting receipts due to updated transactions from the queue, which can only happen for `InitiationSource.purchased`.
For TRIAGE-82.