PurchaseOrchestrator: fix incorrect InitiationSource for SK1 queue transactions
#2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
force-pushed
the
nacho/sdk-2867-ios-code-to-send-headers-in-post-receipt
branch
from
a8dfbdd
to
fc064d5
Compare
|
@aboedo does this look good to you? |
aboedo
reviewed
Apr 24, 2023
Comment on lines
+812
to
+817
| private func initiationSource( | ||
| for productIdentifier: String, | ||
| restored: Bool | ||
| ) -> ProductRequestData.InitiationSource { | ||
| // Having a purchase completed callback implies that the transation comes from an explicit call | ||
| // to `purchase()` instead of a StoreKit transaction notification. |
There was a problem hiding this comment.
I think this works.
I got quite confused at first, since that restore isn't coming from us, and we do offer the ability to attach a completion block to restores when they get initiated through our SDK.
But restores that are coming from us won't actually go through this flow in the first place since they don't issue transactions in the queue. Instead, for our restores we just refresh the receipt and send it.
Maybe we can document that behavior more in detail?
NachoSoto
deleted the
nacho/sdk-2867-ios-code-to-send-headers-in-post-receipt
branch
NachoSoto
added a commit
that referenced
this pull request
Apr 26, 2023
…e transactions (#2430) All StoreKit 1 transactions were being sent with `InitiationSource.purchased`. #1957 introduced this, but it was only set correctly for SK2. The consequence of this is that users might see "invalid receipt" errors when posting receipts due to updated transactions from the queue, which can only happen for `InitiationSource.purchased`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All StoreKit 1 transactions were being sent with
InitiationSource.purchased.#1957 introduced this, but it was only set correctly for SK2.
The consequence of this is that users might see "invalid receipt" errors when posting receipts due to updated transactions from the queue, which can only happen for
InitiationSource.purchased.