Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Release/4.18.0 #2445

Closed
wants to merge 4 commits into from
Closed

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Apr 26, 2023

New Features

This new library allows apps to use a smaller version of the RevenueCat SDK, intended for apps that will do their own entitlement computation separate from RevenueCat.

Apps using this mode rely on webhooks to signal their backends to refresh entitlements with RevenueCat.

See the demo app for an example and usage instructions.

Bugfixes

Other Changes

@NachoSoto NachoSoto requested a review from a team April 26, 2023 06:39
@NachoSoto NachoSoto changed the title Release/4.18.0 [DO NOT MERGE] Release/4.18.0 Apr 26, 2023
@NachoSoto
Copy link
Contributor Author

This includes #2442 cherry-pick, which isn't approved yet. I can update the commit if any changes are required there.

@aboedo
Copy link
Member

aboedo commented Apr 27, 2023

When we ship, let's manually edit release notes to explicitly mention the new mode and provide a link to the readme in the sample app since it contains usage instructions

@NachoSoto
Copy link
Contributor Author

Updated release notes here.

@NachoSoto
Copy link
Contributor Author

Just need to cherry-pick #2452, will do that in a couple of hours.

@aboedo
Copy link
Member

aboedo commented Apr 27, 2023

@NachoSoto I cherry-picked it to 4.17.11 and rebased 4.18.0 on that one, since it looked like that was the logic applied to the rest of the commits

@NachoSoto
Copy link
Contributor Author

Yup perfect!

@aboedo
Copy link
Member

aboedo commented Apr 27, 2023

APITester doesn't work because it's using main, and in main we have a reference to signatureVerificationFailed in API tests (from Trusted Entitlements)

@NachoSoto
Copy link
Contributor Author

APITester doesn't work because it's using main

It shouldn't be using main, the CircleCI job is supposed to change main to the commit hash it's testing. Investigating.

@NachoSoto
Copy link
Contributor Author

Oh I see, we needed to modify the cherry-picked commit slightly to accommodate the current API in that branch. Fixing.

@NachoSoto
Copy link
Contributor Author

Fixed, rebasing.

@NachoSoto
Copy link
Contributor Author

Release notes added in #2461.

@NachoSoto NachoSoto closed this Apr 28, 2023
@NachoSoto NachoSoto deleted the release/4.18.0 branch April 28, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants