Update offerings cache when switchUser(to:) is called #2455
Conversation
| Logger.debug(Strings.identity.switching_user(newUserId: newAppUserID)) | ||
| Logger.debug(Strings.identity.switching_user(newUserID: newAppUserID)) |
There was a problem hiding this comment.
renamed param for consistency with others
| guard self.identityManager.currentAppUserID != newAppUserID else { | ||
| self.logger.warn(Strings.identity.switching_user_same_app_user_id(newUserID: newAppUserID)) | ||
| return | ||
| } |
There was a problem hiding this comment.
we missed this in the original implementation but it becomes a lot more important when a cache update is added to the mix
| func testRefreshesOfferingsCache() { | ||
| expect(self.mockOfferingsManager.invokedUpdateOfferingsCacheCount) == 0 | ||
|
|
||
| self.systemInfo = MockSystemInfo(finishTransactions: true, customEntitlementsComputation: true) |
There was a problem hiding this comment.
This initialization is duplicated in several tests now, might be worth extracting.
| } | ||
|
|
||
| func testSwitchUserNoOpIfAppUserIDIsSameAsCurrent() { | ||
| self.systemInfo = MockSystemInfo(finishTransactions: true, customEntitlementsComputation: true) |
There was a problem hiding this comment.
Ditto duplicated initialization.
|
@NachoSoto I ended up going with a slightly simpler path. And... I think we might wanna do this a bit more tbh, it feels a lot simpler to manage. |
|
|
||
| #if !ENABLE_CUSTOM_ENTITLEMENT_COMPUTATION |
There was a problem hiding this comment.
I think this is backwards?
There was a problem hiding this comment.
LOL I shouldn't be allowed to code. Or at least not automerge
|
Oh they don't yet because APITesters aren't merged. |
|
I disabled auto merge just in case. |
| /// | ||
| /// Updates the current appUserID to a new one, without associating the two. | ||
| /// - Important: This method is **only available** in Custom Entitlements Computation mode. | ||
| /// Receipts posted by the SDK to the RevenueCat backend after calling this method will be sent | ||
| /// with the newAppUserID. | ||
| /// | ||
| @objc(switchUserToNewAppUserID:) | ||
| func switchUser(to newAppUserID: String) { | ||
| public func switchUser(to newAppUserID: String) { | ||
| internalSwitchUser(to: newAppUserID) |
There was a problem hiding this comment.
Nit:
| internalSwitchUser(to: newAppUserID) | |
| self.internalSwitchUser(to: newAppUserID) |
|
@NachoSoto thanks for the catches! Updated |
aboedo
force-pushed
the
andy/sdk-3089-refresh-offerings-cache-after
branch
from
440123a
to
6e41333
Compare
Added updating of offerings cache when `switchUser(to:)` is called. Also added checking that the new appUserID != the current one and no-op if it is.
Added updating of offerings cache when
switchUser(to:)is called.Also added checking that the new appUserID != the current one and no-op if it is.