Custom Entitlement Computation: API testers #2452
Conversation
### Changes: - Created `CustomEntitlementComputationSwiftAPITester` - Cleaned up checks for `ENABLE_CUSTOM_ENTITLEMENT_COMPUTATION` in existing API testers - Running new API tester in CI as part of the Custom Entitlement Computation SPM build
| func checkAttributionAPI() { | ||
| attribution.setAttributes([String: String]()) |
There was a problem hiding this comment.
we shouldn't really even have this be available in this mode, might wanna hide it too. subs attributes shouldn't work
There was a problem hiding this comment.
do they work? i.e.: if you call them right now, do they actually set data?
There was a problem hiding this comment.
I guess it won't work because these are instance methods and there's no public initializer for the type, right?
There was a problem hiding this comment.
Oooh I missed this. Yeah Purchases.attribution is not exposed but I'll hide this too.
Good catch!
There was a problem hiding this comment.
Looking at this now. Hiding Attribution altogether would require a lot of code changes.
It's impossible to use this because you can't access Purchases.attribution, so I think we're good.
I'll remove this file from APITester because we don't actually care about this type in here.
| @@ -179,10 +173,6 @@ + (void)checkAPI { | |||
| [p logIn:@"" completion:^(RCCustomerInfo *i, BOOL created, NSError *e) { }]; | |||
| [p logOutWithCompletion:^(RCCustomerInfo *i, NSError *e) { }]; | |||
|
|
|||
| #if ENABLE_CUSTOM_ENTITLEMENT_COMPUTATION | |||
| [p switchUserToNewAppUserID:@""]; | |||
| #endif | |||
There was a problem hiding this comment.
I noticed we don't have API tests for ObjC for the new mode... But not sure how necessary that is.
|
Merging this. |
### Changes: - Created `CustomEntitlementComputationSwiftAPITester` - Cleaned up checks for `ENABLE_CUSTOM_ENTITLEMENT_COMPUTATION` in existing API testers - Running new API tester in CI as part of the Custom Entitlement Computation SPM build
### Changes: - Created `CustomEntitlementComputationSwiftAPITester` - Cleaned up checks for `ENABLE_CUSTOM_ENTITLEMENT_COMPUTATION` in existing API testers - Running new API tester in CI as part of the Custom Entitlement Computation SPM build
Changes:
CustomEntitlementComputationSwiftAPITesterENABLE_CUSTOM_ENTITLEMENT_COMPUTATIONin existing API testers