Safeguard against nil productIdentifiers or payments #297
Conversation
Purchases/Public/RCPurchases.m
Outdated
| @@ -953,8 +953,11 @@ - (void)handleReceiptPostWithTransaction:(SKPaymentTransaction *)transaction | |||
| [self markAttributesAsSyncedIfNeeded:subscriberAttributes appUserID:self.appUserID error:error]; | |||
|
|
|||
| RCPurchaseCompletedBlock completion = nil; | |||
| NSString *productIdentifier = transaction.payment.productIdentifier; | |||
There was a problem hiding this comment.
let's add nullable since we're going to check for nullabiilty.
we should also maybe add a log entry, in case a future dev looks at the docs and (reasonably) assumes that this should never be nil.
There was a problem hiding this comment.
we could have a method that unwraps the whole thing and RCLogs if we're using it in a couple of places.
There was a problem hiding this comment.
I added it in d735da0, I doubted about making an extension function on SKTransaction, what do you think?
Purchases/Public/RCPurchases.m
Outdated
| - (nullable NSString *)productIdentifierFrom:(SKPaymentTransaction *)transaction | ||
| { |
There was a problem hiding this comment.
nitpick: the { should go at the end,
- (nullable NSString *)productIdentifierFrom:(SKPaymentTransaction *)transaction {
|
It looks like #303 had some tests that could fail depending on the speed of the machine. |
|
#304 should fix the tests |
vegaro
force-pushed
the
cesardelavega/ch698/crash-when-loading-products
branch
from
8207f32
to
a3c8694
Compare
We were assuming
transaction.payment.productIdentifierto not be nil in some places inRCPurchases.This will most likely fix #279