Fix: application state check on app extensions #303
Conversation
…d but its related blocks are done on a back queue
| @@ -20,7 +20,7 @@ NS_ASSUME_NONNULL_BEGIN | |||
| @property(nonatomic, copy, readonly) NSString *platformFlavorVersion; | |||
|
|
|||
|
|
|||
| - (BOOL)isApplicationBackgrounded; | |||
| - (void)isApplicationBackgroundedWithCompletion:(void(^)(BOOL))completion; // calls completion on the main thread | |||
There was a problem hiding this comment.
there might be a better way to document that this returns on the main thread?
| #elif TARGET_OS_TV | ||
| return UIApplication.sharedApplication.applicationState == UIApplicationStateBackground; | ||
| #elif TARGET_OS_OSX | ||
| return NO; | ||
| #elif TARGET_OS_WATCH | ||
| return WKExtension.sharedExtension.applicationState == WKApplicationStateBackground; |
There was a problem hiding this comment.
the other targets should be safe I believe
| } | ||
|
|
||
| - (BOOL)isAppExtension { | ||
| return [NSBundle.mainBundle.bundlePath hasSuffix:@".appex"]; |
There was a problem hiding this comment.
this was taken from MParticle's solution
| [self.systemInfo isApplicationBackgroundedWithCompletion:^(BOOL isBackgrounded) { | ||
| if (!isBackgrounded) { | ||
| dispatch_queue_t backgroundQueue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0); | ||
| dispatch_async(backgroundQueue, ^{ | ||
| [self updateAllCachesWithCompletionBlock:callDelegate]; | ||
| }); | ||
| } else { | ||
| [self sendCachedPurchaserInfoIfAvailable]; | ||
| } | ||
| }]; |
There was a problem hiding this comment.
this is the reason for a lot of the changes in the tests - since we're calling the updateAllCaches method from a background queue, it will take longer to return for tests.
| if let responseNSError = responseError as? NSError { | ||
| successFailed = (status >= 500 | ||
| && data == nil | ||
| && error.domain == responseNSError.domain | ||
| && error.code == responseNSError.code) |
There was a problem hiding this comment.
this had been bugging me for a while - apparently on iOS 14, error != responseError as NSError?.
So this would fail. I'm just manually checking the domain and code, which should suffice for the purposes of the test.
| requestFetcher = MockRequestFetcher() | ||
| systemInfo = MockSystemInfo(platformFlavor: nil, platformFlavorVersion: nil, finishTransactions: true) |
There was a problem hiding this comment.
I think we should be doing this for all mocks - otherwise they just get created once and keep state in between tests.
I'm just doing it here for these two since I had issues, but I'm not 100% it's necessary. I'll check before merging.
…aredApplication method
UIApplication.sharedApplicationisn't available in iOS app extensions. They won't compile if the method is used.Unfortunately, there's no pre-processor macro to check if the code is running within an app extension. There's also no direct API.
Most of the solutions I found online seem to involve adding a custom flag to the app extension target's build settings... which is fine, if you're the app developer. If you're developing an SDK, however, this isn't an option.
I realized that MParticle used to ask developers to create this custom flag, but afterwards removed that and instead they now check if the app's bundle has the filename extension
.appex.This only works at runtime, so I had to refactor the related code a bit: I use KVC to call the method by name, if and only if the code is not running inside an app extension.
That should solve the app extension issue.
On another note, since the code is calling
UIApplicationbut may be running in a background thread, this might raise warnings from the Main Thread Checker (see #300).To address this, I moved the call to
UIApplication.sharedApplicationto the main thread. However, the rest of the method (fetching purchaser info and offerings from the backend) runs in a background operation thread.