Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export xcframeworks #317

Merged
merged 6 commits into from
Aug 26, 2020
Merged

export xcframeworks #317

merged 6 commits into from
Aug 26, 2020

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Aug 19, 2020

Adds a script that allows us to generate xcframeworks.

This is the new format for frameworks, which allows you to pack frameworks built for multiple platforms into a single bundle, where xcode decides which one to use for a given platform, killing the need for lipo.

The format unfortunately doesn't allow for us to pack in the 2 frameworks at once, but it's still a good idea to support it.

remaining work

  • simplify build script via fastlane if available, or via nicer bash scripting if fastlane is a no-go.
  • add it to deploy script

Requirements:

@aboedo aboedo self-assigned this Aug 19, 2020
@aboedo aboedo changed the base branch from develop to feature/modularization_2 August 19, 2020 22:12
@aboedo aboedo added the HOLD label Aug 19, 2020
@aboedo aboedo marked this pull request as ready for review August 20, 2020 17:34
@aboedo aboedo requested a review from vegaro August 20, 2020 17:34
Base automatically changed from feature/modularization_2 to develop August 26, 2020 19:04
@aboedo aboedo removed the HOLD label Aug 26, 2020
@aboedo aboedo merged commit 9706205 into develop Aug 26, 2020
@aboedo aboedo deleted the binary_framework_2 branch August 26, 2020 19:13
@aboedo aboedo mentioned this pull request Aug 27, 2020
@aboedo aboedo mentioned this pull request Sep 10, 2020
@aboedo aboedo mentioned this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants