modularization improvement: static dependency #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
commented
Aug 26, 2020
| // Copyright © 2020 Purchases. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation |
There was a problem hiding this comment.
this file is needed so that Xcode can link swift stuff correctly for the static library dependency. Actually, I'll write that as a comment in the file in case anyone wonders in the future.
aboedo
force-pushed
the
binary_framework_2
branch
from
b1f4fbc
to
84810b9
Compare
… to Purchases, added dummy Swift file to Purchases
aboedo
force-pushed
the
modularization_4
branch
from
7056c1b
to
e8f4bc5
Compare
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a couple of updates to our modularization system:
PurchasesCoreSwiftis now static instead of dynamicPurchasesuses the-all_loadlinker flag.This makes it so that developers won't need to make any changes to their code in order to use the swift stuff, meaning that they don't have to manually link
PurchasesCoreSwiftor even know that it exists.The changes here were inspired by this (excellent) blog entry that proposes a modularized structure for iOS apps:
https://medium.com/fluxom/building-a-dynamic-modular-ios-architecture-1b87dc31278b
Tested on:
Tested by running the app on physical device, calling methods from the SDK, in particular using the
Transactionand `nonSubscriptionTransactions, since those were the problematic ones for #314.As well as running the app on each package manager / build system, I also made an archive.
Requirements: