Update release script #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
vegaro
reviewed
Aug 26, 2020
| @@ -30,7 +30,7 @@ platform :ios do | |||
| lane :bump do |options| | |||
| new_version_number = options[:version] | |||
| fail ArgumentError, "missing version" unless new_version_number | |||
| previous_version_number = get_version_number | |||
| previous_version_number = get_version_number(target: "Purchases") | |||
| increment_version_number(version_number: new_version_number) | |||
There was a problem hiding this comment.
so this increases the version number in both PurchasesCoreSwift and Purchases??
There was a problem hiding this comment.
yep! I tried it and it works.
increment_version_number is just a wrapper around Apple's avgtool, and it doesn't distinguish between targets, it updates for all targets in the project (including test targets)
aboedo
force-pushed
the
modularization_4
branch
from
7056c1b
to
e8f4bc5
Compare
… and specifying the target when obtaining the version number
aboedo
force-pushed
the
update_release_script
branch
from
6fa3a6f
to
b48575a
Compare
vegaro
approved these changes
Aug 26, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the release script
PurchasesCoreSwiftpod before thePurchasespod and dopod repo updateRequirements:
Based on modularization improvement: static dependency #319