Integration Tests: prevent false positives when purchasing returns 5xx
#3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
commented
Sep 14, 2023
Comment on lines
+137
to
+163
| func verifyCustomerInfoWasComputedOffline( | ||
| logger: TestLogHandler? = nil, | ||
| file: FileString = #file, | ||
| line: UInt = #line | ||
| ) { | ||
| let logger: TestLogHandler = logger ?? self.logger | ||
| logger.verifyMessageWasLogged( | ||
| Strings.offlineEntitlements.computing_offline_customer_info, | ||
| level: .info, | ||
| file: file, | ||
| line: line | ||
| ) | ||
| } | ||
|
|
||
| func verifyCustomerInfoWasNotComputedOffline( | ||
| logger: TestLogHandler? = nil, | ||
| file: FileString = #file, | ||
| line: UInt = #line | ||
| ) { | ||
| let logger: TestLogHandler = logger ?? self.logger | ||
|
|
||
| logger.verifyMessageWasNotLogged( | ||
| Strings.offlineEntitlements.computing_offline_customer_info, | ||
| file: file, | ||
| line: line | ||
| ) | ||
| } |
There was a problem hiding this comment.
These are the new methods
NachoSoto
commented
Sep 14, 2023
| self.verifyNoTransactionsWereFinished() | ||
| } | ||
|
|
||
| @available(iOS 15.0, tvOS 15.0, watchOS 8.0, macOS 12.0, *) | ||
| func testPurchaseWhileServerIsDownPostsReceiptAfterServerComesBack() async throws { | ||
| self.logger.clearMessages() |
There was a problem hiding this comment.
Small improvement in this test. The verifyNoTransactionsWereFinished was being affected by leftover transaction before the test started.
NachoSoto
force-pushed
the
paywalls
branch
2 times, most recently
from
831bc21
to
66b5048
Compare
NachoSoto
force-pushed
the
integration-tests-false-positive-5xx
branch
from
e30660c
to
aa6582b
Compare
NachoSoto
changed the base branch from
paywalls
to
integration-test-flaky-failures-3
Base automatically changed from
integration-test-flaky-failures-3
to
paywalls
September 15, 2023 00:08
tonidero
approved these changes
Sep 15, 2023
NachoSoto
force-pushed
the
integration-tests-false-positive-5xx
branch
from
aa6582b
to
967861c
Compare
Good news: offline entitlements are amazing, and our SDK is very resilient to the backend being down. Bad news: this is kind of a false positive, this behavior is already verified by `OfflineStoreKitIntegrationTests`. I refactored `BaseStoreKitIntegrationTests` because it had grown a lot. I put this verification in the `purchase` methods so all tests benefit from this. So that `OfflineStoreKitIntegrationTests` doesn't fail, I added a parameter to ignore those there.
NachoSoto
force-pushed
the
integration-tests-false-positive-5xx
branch
from
967861c
to
0850d71
Compare
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good news: offline entitlements are amazing, and our SDK is very resilient to the backend being down.
Bad news: this is kind of a false positive, this behavior is already verified by
OfflineStoreKitIntegrationTests.I refactored
BaseStoreKitIntegrationTestsbecause it had grown a lot. I put this verification in thepurchasemethods so all tests benefit from this.So that
OfflineStoreKitIntegrationTestsdon't fail, I added a parameter to ignore that verification in those tests.