Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Tests: prevent false positives when purchasing returns 5xx #3209

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Integration Tests: prevent false positives when purchasing returns 5xx #3209

merged 2 commits into from
Sep 18, 2023

Commits on Sep 15, 2023

  1. Integration Tests: prevent false positives when purchasing returns 5xx 

    Good news: offline entitlements are amazing, and our SDK is very resilient to the backend being down.
Bad news: this is kind of a false positive, this behavior is already verified by `OfflineStoreKitIntegrationTests`.

I refactored `BaseStoreKitIntegrationTests` because it had grown a lot.
I put this verification in the `purchase` methods so all tests benefit from this.

So that `OfflineStoreKitIntegrationTests` doesn't fail, I added a parameter to ignore those there.
    @NachoSoto
    NachoSoto committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    18c2a8f View commit details
    Browse the repository at this point in the history

  2. Fixed test

    @NachoSoto
    NachoSoto committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    0850d71 View commit details
    Browse the repository at this point in the history