fix cocoapods and carthage release scripts #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
changed the title
aboedo
commented
Aug 28, 2020
Purchases.podspec
Outdated
| @@ -22,7 +22,7 @@ Pod::Spec.new do |s| | |||
| s.tvos.deployment_target = '9.0' | |||
|
|
|||
| s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' } | |||
| s.dependency 'PurchasesCoreSwift' | |||
| s.dependency 'PurchasesCoreSwift', '3.6.0-beta-2' | |||
There was a problem hiding this comment.
I'll add this to the list of things for fastlane to auto-bump
aboedo
force-pushed
the
fix/add_explicit_version_to_prerelease_pod
branch
from
b918c63
to
662d99d
Compare
|
@vegaro bump |
vegaro
approved these changes
Sep 1, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cocoapods
pod trunk pushfailed because for pre-release versions, you need to specify the exact version number, and we had3.6.0-beta-2.I finished the process manually, but this gets it fixed for next time.
Carthage
Also fixes carthage.
carthage build --archivewould fail, because it was trying to create two archives (one forPurchasesand one forPurchasesCoreSwift.Fixed by separating the shorthand
carthage build --archiveintoXCFrameworks
Turns out the
xcframeworksfastlane plugin isn't compatible with static libraries, so the xcframeworks generation is broken.We might want to roll it back to where it was before this commit:
3765e6f
And build from there, but that's for another day.