Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cocoapods and carthage release scripts #324

Merged
merged 3 commits into from
Sep 1, 2020
Merged

fix cocoapods and carthage release scripts #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f870df0
updated the carthage build step since we now have two schemes
aboedo Aug 28, 2020
2488a80
update fastlane
aboedo Aug 28, 2020
662d99d
removed xcframeworks plugin since it's not compatible with static lib…
aboedo Aug 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ GEM
json (>= 1.5.1)
atomos (0.1.3)
aws-eventstream (1.1.0)
aws-partitions (1.359.0)
aws-partitions (1.362.0)
aws-sdk-core (3.105.0)
aws-eventstream (~> 1, >= 1.0.2)
aws-partitions (~> 1, >= 1.239.0)
Expand All @@ -23,7 +23,7 @@ GEM
aws-sdk-kms (1.37.0)
aws-sdk-core (~> 3, >= 3.99.0)
aws-sigv4 (~> 1.1)
aws-sdk-s3 (1.79.0)
aws-sdk-s3 (1.79.1)
aws-sdk-core (~> 3, >= 3.104.3)
aws-sdk-kms (~> 1)
aws-sigv4 (~> 1.1)
Expand Down Expand Up @@ -89,7 +89,7 @@ GEM
faraday_middleware (1.0.0)
faraday (~> 1.0)
fastimage (2.2.0)
fastlane (2.156.1)
fastlane (2.157.2)
CFPropertyList (>= 2.3, < 4.0.0)
addressable (>= 2.3, < 3.0.0)
aws-sdk-s3 (~> 1.0)
Expand Down Expand Up @@ -144,7 +144,7 @@ GEM
google-cloud-env (1.3.3)
faraday (>= 0.17.3, < 2.0)
google-cloud-errors (1.0.1)
google-cloud-storage (1.27.0)
google-cloud-storage (1.28.0)
addressable (~> 2.5)
digest-crc (~> 0.4)
google-api-client (~> 0.33)
Expand Down
3 changes: 2 additions & 1 deletion bin/release_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ pod trunk push Purchases.podspec

echo "Preparing Carthage release"
echo "building..."
carthage build --archive
carthage build --no-skip-current
carthage archive Purchases

echo "creating uploads folder if needed"
mkdir $CARTHAGE_UPLOADS_PATH
Expand Down
33 changes: 1 addition & 32 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,16 +55,14 @@ platform :ios do
fail "please add a CHANGELOG.latest.md file before calling this lane"
end

xcframeworks_zip_path = export_xcframeworks(output_directory: "builds/xcframeworks")

set_github_release(
repository_name: "revenuecat/purchases-ios",
api_token: ENV["GITHUB_TOKEN"],
name: release_version,
tag_name: "#{release_version}",
description: changelog,
commitish: "master",
upload_assets: ["CarthageUploads/Purchases.framework.zip", xcframeworks_zip_path],
upload_assets: ["CarthageUploads/Purchases.framework.zip"],
is_draft: false
)
end
Expand All @@ -83,35 +81,6 @@ platform :ios do
Spaceship::Tunes::SandboxTester.create!(email: email, password: password)
end

desc "Export XCFrameworks"
lane :export_xcframeworks do |options|
output_directory = options[:output_directory]
fail ArgumentError, "missing output directory" unless output_directory

platforms = [
'iOS',
'macOS',
'tvOS',
'watchOS'
]
create_xcframework(
destinations: platforms,
scheme: 'PurchasesCoreSwift',
xcframework_output_directory: output_directory
)

create_xcframework(
destinations: platforms,
scheme: 'Purchases',
xcframework_output_directory: output_directory
)

xcframeworks_zip_path = output_directory + ".zip"
zip(path: output_directory,
output_path: xcframeworks_zip_path)
return xcframeworks_zip_path
end

end

def increment_build_number(previous_version_number, new_version_number, file_path)
Expand Down