PaywallsTester: add a new tab that calls presentPaywallIfNeeded #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
commented
Sep 28, 2023
| @@ -108,7 +115,7 @@ struct AppContentView: View { | |||
| if let stream = self.customerInfoStream { | |||
| for await info in stream { | |||
| self.customerInfo = info | |||
| self.showingDefaultPaywall = info.activeSubscriptions.count == 0 | |||
| self.showingDefaultPaywall = self.showingDefaultPaywall && info.activeSubscriptions.count == 0 | |||
There was a problem hiding this comment.
oops this was a bug in #3256, it would still show the paywall every time 😅
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3259 +/- ##
==========================================
- Coverage 85.93% 85.92% -0.02%
==========================================
Files 233 233
Lines 16657 16657
==========================================
- Hits 14315 14313 -2
- Misses 2342 2344 +2 ☔ View full report in Codecov by Sentry. |
NachoSoto
approved these changes
Oct 2, 2023
| import SwiftUI | ||
|
|
||
| struct UpsellView: View { | ||
| var body: some View { |
There was a problem hiding this comment.
Nit: space per our style guide.
Comment on lines
16
to
17
| This is achieved by calling | ||
| `.presentPaywallIfNeeded(requiredEntitlementIdentifier: \(Configuration.entitlement)) |
There was a problem hiding this comment.
Love it. Small typo:
Suggested change
| This is achieved by calling | |
| `.presentPaywallIfNeeded(requiredEntitlementIdentifier: \(Configuration.entitlement)) | |
| This is achieved by calling | |
| `.presentPaywallIfNeeded(requiredEntitlementIdentifier: \(Configuration.entitlement))` |
|
|
||
| struct UpsellView: View { | ||
| var body: some View { | ||
| VStack { |
There was a problem hiding this comment.
I planned on adding more things initially, but never got around to it. I can remove this for now
aboedo
force-pushed
the
andy/pwl-297-paywallstester-new-tab-for-presentpaywallifneeded
branch
from
f18e551
to
7ebd5fd
Compare
aboedo
deleted the
andy/pwl-297-paywallstester-new-tab-for-presentpaywallifneeded
branch
tonidero
pushed a commit
that referenced
this pull request
Oct 3, 2023
**This is an automatic release.** ### New Features * Add `Attribution.setOnesignalUserID` (#3268) via Raquel Diez (@Raquel10-RevenueCat) * StoreKit In App messages support (#3252) via Toni Rico (@tonidero) ### Other Changes * Remove ObjC showStoreMessages API (#3269) via Toni Rico (@tonidero) * PaywallsTester: add a new tab that calls presentPaywallIfNeeded (#3259) via Andy Boedo (@aboedo) * `Paywalls`: small PaywallsTester refactor (#3261) via NachoSoto (@NachoSoto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new tab that calls
presentPaywallIfNeeded