-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Attribution.setOnesignalUserID
#3268
Merged
NachoSoto
merged 3 commits into
main
from
raquel10/fia-1538-onesignal-integration-changes
Oct 3, 2023
Merged
Add Attribution.setOnesignalUserID
#3268
NachoSoto
merged 3 commits into
main
from
raquel10/fia-1538-onesignal-integration-changes
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
approved these changes
Oct 3, 2023
Comment on lines
+46
to
+47
attribution.setOnesignalUserID("") | ||
attribution.setOnesignalUserID(nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Raquel10-RevenueCat
changed the title
Add onesignalUserId reserved attribute
Add Attribution.setOnesignalUserID
Oct 3, 2023
NachoSoto
changed the title
Add Attribution.setOnesignalUserID
Add Oct 3, 2023
Attribution.setOnesignalUserID
tonidero
pushed a commit
that referenced
this pull request
Oct 3, 2023
**This is an automatic release.** ### New Features * Add `Attribution.setOnesignalUserID` (#3268) via Raquel Diez (@Raquel10-RevenueCat) * StoreKit In App messages support (#3252) via Toni Rico (@tonidero) ### Other Changes * Remove ObjC showStoreMessages API (#3269) via Toni Rico (@tonidero) * PaywallsTester: add a new tab that calls presentPaywallIfNeeded (#3259) via Andy Boedo (@aboedo) * `Paywalls`: small PaywallsTester refactor (#3261) via NachoSoto (@NachoSoto)
Raquel10-RevenueCat
added a commit
that referenced
this pull request
Nov 13, 2023
This reverts commit acb01f6.
Raquel10-RevenueCat
added a commit
that referenced
this pull request
Nov 14, 2023
This reverts commit bd91c89.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
OneSignal is migrating to a new User Centric API (v11.0). Adding a new reserved attribute to provide the new OneSignal User Id.
Description