Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Attribution.setOnesignalUserID #3268

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

Raquel10-RevenueCat
Copy link
Contributor

Motivation

OneSignal is migrating to a new User Centric API (v11.0). Adding a new reserved attribute to provide the new OneSignal User Id.

Description

  • Added $onesignalUserId reserved attribute with setter methods

@NachoSoto NachoSoto added the pr:feat A new feature label Oct 3, 2023
@NachoSoto NachoSoto requested a review from a team October 3, 2023 15:42
Comment on lines +46 to +47
attribution.setOnesignalUserID("")
attribution.setOnesignalUserID(nil)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Raquel10-RevenueCat Raquel10-RevenueCat marked this pull request as ready for review October 3, 2023 15:49
@Raquel10-RevenueCat Raquel10-RevenueCat changed the title Add onesignalUserId reserved attribute Add Attribution.setOnesignalUserID Oct 3, 2023
@NachoSoto NachoSoto changed the title Add Attribution.setOnesignalUserID Add Attribution.setOnesignalUserID Oct 3, 2023
@NachoSoto NachoSoto enabled auto-merge (squash) October 3, 2023 16:04
@NachoSoto NachoSoto merged commit acb01f6 into main Oct 3, 2023
18 of 19 checks passed
@NachoSoto NachoSoto deleted the raquel10/fia-1538-onesignal-integration-changes branch October 3, 2023 16:38
tonidero pushed a commit that referenced this pull request Oct 3, 2023
**This is an automatic release.**

### New Features
* Add `Attribution.setOnesignalUserID` (#3268) via Raquel Diez
(@Raquel10-RevenueCat)
* StoreKit In App messages support (#3252) via Toni Rico (@tonidero)
### Other Changes
* Remove ObjC showStoreMessages API (#3269) via Toni Rico (@tonidero)
* PaywallsTester: add a new tab that calls presentPaywallIfNeeded
(#3259) via Andy Boedo (@aboedo)
* `Paywalls`: small PaywallsTester refactor (#3261) via NachoSoto
(@NachoSoto)
Raquel10-RevenueCat added a commit that referenced this pull request Nov 13, 2023
Raquel10-RevenueCat added a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants