Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support for StoreKit 2 full flow #3529

Closed
wants to merge 4 commits into from
Closed

Conversation

MarkVillacampa
Copy link
Member

@MarkVillacampa MarkVillacampa commented Dec 20, 2023

Umbrella branch + PR to track work on adding support for full flow StoreKit 2 mode.

Changes:

TODO:

  • rebase/merge so we can keep the history of each commit
  • Remove 7d07642 to address the conflicts. We don't actually need that commit in main
  • We'll need one of the PRs in this branch to be tagged as breaking

@MarkVillacampa MarkVillacampa added the pr:feat A new feature label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (65028b8) 85.88% compared to head (5c9d018) 85.96%.

❗ Current head 5c9d018 differs from pull request most recent head 7d07642. Consider uploading reports for the commit 7d07642 to get more accurate results

Files Patch % Lines
Sources/Misc/StoreKitVersion.swift 83.87% 5 Missing ⚠️
Sources/Purchasing/Purchases/Purchases.swift 71.42% 2 Missing ⚠️
Sources/Logging/Strings/ConfigureStrings.swift 66.66% 1 Missing ⚠️
Sources/Support/DebugUI/DebugViewModel.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3529      +/-   ##
==========================================
+ Coverage   85.88%   85.96%   +0.08%     
==========================================
  Files         242      240       -2     
  Lines       17617    17490     -127     
==========================================
- Hits        15131    15036      -95     
+ Misses       2486     2454      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NachoSoto
Copy link
Contributor

Notes for this PR:

  • I'd recommend rebase/merge so we can keep the history of each commit
  • Remove 7d07642 to address the conflicts. We don't actually need that commit in main
  • We'll need one of those PRs to be tagged as breaking

…n of StoreKit to use (#3487)

This PR introduces a new configuration option to select the StoreKit
version to use.

It supersedes the deprecated `.with(usesStoreKit2IfAvailable: true)` and
the internal `usesStoreKit2JWS` configuration options.

Uses JWS tokens instead of SK1 receipts when in StoreKit 2 mode where
applicable.

Example usage:
```swift
Purchases.configure(
            with: .builder(withAPIKey: apiKey)
                .with(storeKitVersion: .storeKit2)
                .build()
```
Default to StoreKit 1 when enabling observer mode.
@MarkVillacampa
Copy link
Member Author

Closing as commits from this PR have been included in #3652

@vegaro vegaro deleted the sk2-full-flow branch March 21, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat:StoreKit 2 pr:breaking Changes that are breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants