Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 #3615

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

@NachoSoto NachoSoto added HOLD pr:breaking Changes that are breaking labels Jan 30, 2024
@NachoSoto NachoSoto requested a review from a team January 30, 2024 20:50
NachoSoto added a commit that referenced this pull request Jan 30, 2024
NachoSoto added a commit that referenced this pull request Jan 30, 2024
@NachoSoto
Copy link
Contributor Author

Holding until we're ready to release the major with #3582 and #3529.

NachoSoto added a commit that referenced this pull request Jan 30, 2024
NachoSoto added a commit that referenced this pull request Jan 30, 2024
NachoSoto added a commit that referenced this pull request Feb 1, 2024
Copy link
Member

@MarkVillacampa MarkVillacampa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY!

@NachoSoto NachoSoto mentioned this pull request Feb 7, 2024
@MarkVillacampa
Copy link
Member

iOS 15 tests seem to be failing consistently here:

Testing failed:
        UnitTestsHostApp (8762) encountered an error (Early unexpected exit, operation never finished bootstrapping - no restart will be attempted. (Underlying Error: Crash: UnitTestsHostApp (8762) type metadata completion function for MockStoreMessage. If you believe this error represents a bug, please attach the result bundle at /Users/distiller/purchases-ios/fastlane/test_output/xctest/ios/RevenueCat.xcresult))

@NachoSoto NachoSoto changed the base branch from main to mock-message-crash February 7, 2024 16:58
@NachoSoto
Copy link
Contributor Author

I just rebased this off of #3650 which I think will fix that.

@MarkVillacampa MarkVillacampa changed the base branch from mock-message-crash to 5.0-dev February 7, 2024 17:57
NachoSoto added a commit that referenced this pull request Feb 7, 2024
@NachoSoto NachoSoto removed the HOLD label Feb 7, 2024
@NachoSoto
Copy link
Contributor Author

@MarkVillacampa feel free to merge this :)

@MarkVillacampa MarkVillacampa enabled auto-merge (squash) February 7, 2024 18:51
@MarkVillacampa MarkVillacampa merged commit 1f76bb7 into 5.0-dev Feb 7, 2024
24 checks passed
NachoSoto added a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:breaking Changes that are breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants