Replace withCheckedThrowingContinuation Calls With withUnsafeThrowingContinuation #4286
Conversation
|
@RCGitBot please test |
| return try await withCheckedThrowingContinuation { continuation in | ||
| return try await withUnsafeThrowingContinuation { continuation in |
There was a problem hiding this comment.
let’s add a comment pointing to the issue for future reference
|
@fire-at-will thanks for taking care of this! |
|
We’ve tested the branch, and it resolves the crash on launch. However, when opening the paywall, it crashes again, this time in withCheckedContinuation: |
|
@kristofferbv thanks so much for reporting back! I've updated the branch to replace all instances of |
Thanks! It works now with the latest changes. It would be really helpful if you could merge this branch into main. |
|
@RCGitBot please test |
|
@kristofferbv thanks for confirming! Merging to main now, will go out in the next release, likely today or tomorrow |
…Continuation (#4286) * replace withCheckedThrowingContinuation calls with withUnsafeThrowingContinuation * replaced instances of withCheckedContinuation -> withUnsafeContinuation * update the links in comments to point to the issue not the PR * linting --------- Co-authored-by: andy boedo <andresboedo@gmail.com>
…Continuation (RevenueCat#4286) * replace withCheckedThrowingContinuation calls with withUnsafeThrowingContinuation * replaced instances of withCheckedContinuation -> withUnsafeContinuation * update the links in comments to point to the issue not the PR * linting --------- Co-authored-by: andy boedo <andresboedo@gmail.com>
Motivation
iOS 18 introduces a bug in Swift that causes calls to
withCheckedThrowingContinuationto crash in certain scenarios. This PR provides some promise in addressing this issue, documented in #4177Description
This PR replaces all calls to
withCheckedThrowingContinuationtowithUnsafeThrowingContinuation, which we're unable to reproduce the issue with.Other Notes
withUnsafeThrowingContinuationdoesn't provide any checking to ensure that the continuation isn't called multiple times, so this is something we'll need to be aware of going forward. Luckily, all existing usages ofwithCheckedThrowingContinuationwere in just a few files and in small functions, so this is easy to check manually for now.