Fix crash in withCheckedContinuation on iOS 18.0 #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
I've seen crashes on iOS 18.0 in our iOS app in the code of this SDK. The crash seems to be the same as in other SDKs, that use
withCheckedContinuation
, which is actually a bug in iOS 18.0 (apparently fixed on iOS 18.1).The easy fix for the crash is to use
withUnsafeContinuation
instead, which only has the downside of no longer checking (and logging) if the continuation is not continued/finished.This PR applies this fixed everywhere in the SDK to hopefully resolve this issue.
Crash Log:
Related issues (only if applicable)
Provide links to issues relating to this pull request
Requirement checklist (only if applicable)