Fixed Pilus Physics Size

[CoreyHendrey]

Pilus physics size now takes into account the organelles scale.

There is a commit here that uses a really crappy debug mesh that matches the pilus physics cylinder (because no matter what I did I couldn't get Debug Collision Shapes to show the damn cylinder).

Small (no scaling):

Just before splitting:

Closed #1064

[athariqk]

I'd say this works just fine from a quick testing

[hhyyrylainen]

One worry with this that I have is that this impacts performance a lot. I think that adjusting the size is a good thing, but if each cell that is growing gets their pilus physics recreated each frame, that's not super nice. Instead I think that the pilus could also be made so that it doesn't change size when it grows and just keep the initial size adjustements from this.

[hhyyrylainen]

The debug draw has been broken for cells from the start. I reopened the issue about that: #1095
I think that, that and a bunch of the other physics issues are caused by the same underlying reason.

[athariqk]

Heh, didn't think of that. Well looks like those has to be fixed I guess

[CoreyHendrey]

Yeah I could change it like that. It was adding the shape every frame before my commit though, but I agree with your reasoning. I'll try and make the Pilus not grow. Maybe it's best done by adding a "ShouldScale" flag to the organelles.

I seem your posts about the debug draw, pain in the butt! My solution works for very temporary testing purposes (adding a mesh and applying the same transforms that you apply to the CollissionShape). Will be great when all the physics stuff is sorted out.

[hhyyrylainen]

It's definitely a bug if it is readding the pilus each frame, it should only add it again if the position where it should be changed.

👍 for organelle flag controlling if an organelle visually grows or not, should also be applied to the nucleus.

[athariqk]

Seems good in-game no errors or anything

[CoreyHendrey]

Ok - OnPositionChanged no longer gets called every frame. Hopefully this helps the flagella as well.

[hhyyrylainen]

Code is good. @Kasterisk could you recheck that gameplay still works?

[athariqk]

It plays fine