Remove request body from DELETE operations in OpenAPI spec
#821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rc/open-api.ts` change from previous commit
RobinTail
reviewed
Feb 26, 2023
RobinTail
changed the title
DELETE operations in OpenAPI spec
RobinTail
approved these changes
Feb 26, 2023
RobinTail
added a commit
that referenced
this pull request
Feb 28, 2023
* Remove request body from delete operations in OpenAPI spec * Remove `DELETE` request `body` from `defaultInputSources` + revert `src/open-api.ts` change from previous commit * Fix test name, add couple todos. * Testing fallback input sources for unknown request methods. * Updating the workflows to run in this branch. --------- Co-authored-by: Robin Tail <robin_tail@me.com>
RobinTail
added a commit
that referenced
this pull request
Mar 4, 2023
* Remove request body from `DELETE` operations in OpenAPI spec (#821) * Remove request body from delete operations in OpenAPI spec * Remove `DELETE` request `body` from `defaultInputSources` + revert `src/open-api.ts` change from previous commit * Fix test name, add couple todos. * Testing fallback input sources for unknown request methods. * Updating the workflows to run in this branch. --------- Co-authored-by: Robin Tail <robin_tail@me.com> * Readme: reflecting the changes, including the config type description. * Changelog: version 9.0.0-beta1, describing the potentially breaking changes. * V9 is for Brianna Ghey. * Updating the workflows to support the future branch of v8. * Updating the Security policy. * 9.0.0-beta1 * Solving the problem #787 (#819) * The proposed solution. * Changing the name of the error. * Adding originalError prop. * The proposed solution. * Changing the name of the error. * Adding originalError prop. * Ref: the solution based on the consistency of OutputValidationError and InputValidationError. * Exposing getMessageFromError() and getStatusCodeFromError() helpers. * Enabling workflows. * Testing the edge cases. * Testing the inheritance of InputValidationError. * Adding the specific test for the problem #787. * Revert "Enabling workflows." This reverts commit c71689b. * Handling the edge case when the issues array is empty. * Changelog: v9.0.0-beta2, describing the potenitally breaking changes. * Readme: updating the instructions on creating a custom ResultHandler. * 9.0.0-beta2 * Changelog: the response may actually not be json. * Changelog: a note on base for 9.0.0-beta1. * Changelog: upcoming v9.0.0-beta3. * 9.0.0-beta3 * Breaking: removing createApiResponse(). * Ref: moving the array initializer for scopes and tags. * Replacing mimeTypes parameter with hasUpload, moving mime types initialization to constructor. * Ref: figuring out hasUpload inside the constructor. * Ref: single method for getMimeTypes() with variants. * Ref: moving response schema and status codes initializations into constructor. * Ref: single method for getStatusCode() with variants. * Ref: removing getOutputSchema() - redundant. * Ref: single method for getSchema() with variants and overloads. * Ref: extracting variant types. * Fix: using ZodTypeAny where anything is implied. * Changelog: upcoming 9.0.0-beta4. * Minor: fix typo. * 9.0.0-beta4 --------- Co-authored-by: Aleksandr Sidorenko <mcmerph@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #820