Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The v9 is for Brianna Ghey #838

Merged
merged 36 commits into from
Mar 4, 2023
Merged

The v9 is for Brianna Ghey #838

merged 36 commits into from
Mar 4, 2023

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Feb 26, 2023

image

On 11 February 2023, Brianna Ghey, a 16-year-old British transgender girl from Birchwood in Warrington, Cheshire, England, was killed in Culcheth Linear Park in Culcheth, Warrington. Two accused teenagers, a boy and a girl both aged 15, are in police custody, having been charged with murder four days after the incident. A motive has not been established and police are investigating "all lines of inquiry", including investigating the killing as a possible hate crime

https://en.wikipedia.org/wiki/Killing_of_Brianna_Ghey

Closes #820

McMerph and others added 4 commits February 26, 2023 19:41
* Remove request body from delete operations in OpenAPI spec

* Remove `DELETE` request `body` from `defaultInputSources` + revert `src/open-api.ts` change from previous commit

* Fix test name, add couple todos.

* Testing fallback input sources for unknown request methods.

* Updating the workflows to run in this branch.

---------

Co-authored-by: Robin Tail <robin_tail@me.com>
@RobinTail RobinTail added the documentation Improvements or additions to documentation label Feb 26, 2023
@RobinTail
Copy link
Owner Author

🚀 v9.0.0-beta1 released, tag beta

* The proposed solution.

* Changing the name of the error.

* Adding originalError prop.

* The proposed solution.

* Changing the name of the error.

* Adding originalError prop.

* Ref: the solution based on the consistency of OutputValidationError and InputValidationError.

* Exposing getMessageFromError() and getStatusCodeFromError() helpers.

* Enabling workflows.

* Testing the edge cases.

* Testing the inheritance of InputValidationError.

* Adding the specific test for the problem #787.

* Revert "Enabling workflows."

This reverts commit c71689b.
@RobinTail RobinTail changed the title v9 is for Brianna Ghey The v9 is for Brianna Ghey Feb 26, 2023
src/common-helpers.ts Outdated Show resolved Hide resolved
@RobinTail
Copy link
Owner Author

🚀 v9.0.0-beta2 released, tag beta

@RobinTail
Copy link
Owner Author

🚀 v9.0.0-beta3 released, tag beta

@RobinTail
Copy link
Owner Author

Now I wanna do a cleanup and refactoring of Endpoint and remove createApiResponse()

@RobinTail RobinTail added the breaking Backward incompatible changes label Mar 2, 2023
Comment on lines +55 to +56
.getSchema("positive")
.or(endpoint.getSchema("negative")),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting...

Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, so far.

@RobinTail
Copy link
Owner Author

🚀 v9.0.0-beta4 released, tag beta

@RobinTail RobinTail marked this pull request as ready for review March 4, 2023 11:01
@@ -13,10 +13,10 @@ name: "CodeQL"

on:
push:
branches: [ master, v7 ]
branches: [ master, v8 ]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v8 branch created

Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine 🤞🏽

@RobinTail RobinTail merged commit da9d687 into master Mar 4, 2023
@RobinTail RobinTail deleted the v9-beta branch March 4, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Backward incompatible changes dedication documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DELETE endpoints with requestBody leads to an OpenAPI semantic error
2 participants