Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python dependencies from drake.cps #10416

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Remove Python dependencies from drake.cps #10416

merged 1 commit into from
Jan 16, 2019

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Jan 15, 2019 •
edited
Loading

Relates #10408. Needs a Shambhala update (RobotLocomotion/drake-external-examples#126).

This change is Reviewable

@jamiesnape jamiesnape mentioned this pull request Jan 15, 2019
Merged
@jamiesnape
Copy link
Contributor Author

+@EricCousineau-TRI for feature review.

EricCousineau-TRI
EricCousineau-TRI approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Can you make a PSA on #python for CMake stuff once this lands?

Reviewed 2 of 2 files at r1.
Reviewable status: all discussions resolved, platform LGTM from [ericcousineau-tri], labeled "do not merge"

EricCousineau-TRI
EricCousineau-TRI approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@SeanCurtis-TRI for platform review, please.

Reviewable status: all discussions resolved, platform LGTM from [ericcousineau-tri], labeled "do not merge"

jwnimmer-tri
jwnimmer-tri approved these changes Jan 16, 2019
View reviewed changes
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: platform since I was reading this anyway, and so -@SeanCurtis-TRI.

Reviewed 2 of 2 files at r1.
Reviewable status: all discussions resolved, LGTM missing from assignee seancurtis-tri, platform LGTM from [ericcousineau-tri, jwnimmer-tri], labeled "do not merge"

@jamiesnape jamiesnape merged commit ea88ce3 into RobotLocomotion:master Jan 16, 2019
@jamiesnape jamiesnape deleted the remove-python-from-drake-cps branch January 16, 2019 13:11
@jamiesnape jamiesnape mentioned this pull request Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricCousineau-TRI EricCousineau-TRI EricCousineau-TRI approved these changes

@jwnimmer-tri jwnimmer-tri jwnimmer-tri approved these changes

Assignees

@jwnimmer-tri jwnimmer-tri

@EricCousineau-TRI EricCousineau-TRI

Labels
configuration: cmake unused team: kitware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamiesnape @jwnimmer-tri @EricCousineau-TRI @SeanCurtis-TRI