Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of deprecated Starlark java provider with JavaInfo provider #11406

Merged
merged 1 commit into from
May 7, 2019
Merged

Replace usage of deprecated Starlark java provider with JavaInfo provider #11406

merged 1 commit into from
May 7, 2019

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented May 7, 2019

Relates bazelbuild/bazel#7598.


This change is Reviewable

@jamiesnape
Copy link
Contributor Author

+@jwnimmer-tri for feature and platform review.

@jwnimmer-tri jwnimmer-tri added the status: single reviewer ok https://drake.mit.edu/reviewable.html label May 7, 2019
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: +(status: single reviewer ok)

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform)

@jamiesnape jamiesnape merged commit c40ad7d into RobotLocomotion:master May 7, 2019
@jamiesnape jamiesnape deleted the incompatible-disallow-legacy-java-provider branch May 7, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants