Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort: Add configuration file and apply to Python files #13709

Conversation

EricCousineau-TRI
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI commented Jul 19, 2020

Towards #13571

Preview of applying isort


This change is Reviewable

Copy link
Contributor Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)


bindings/pydrake/doc/gen_sphinx.py, line 11 at r1 (raw file):

import pydrake.all
# TODO(eric.cousineau): Make an optional `.all` module.

This comment being duplicated smells like a bug with isort==5.1.2.

@EricCousineau-TRI EricCousineau-TRI changed the title isort: Add configuration file isort: Add configuration file and apply to Python files Jul 19, 2020
Copy link
Contributor Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)


bindings/pydrake/doc/gen_sphinx.py, line 11 at r1 (raw file):

Previously, EricCousineau-TRI (Eric Cousineau) wrote…

This comment being duplicated smells like a bug with isort==5.1.2.

Fixed! PyCQA/isort#1328 (comment)

@SeanCurtis-TRI
Copy link
Contributor

Last code changes, last July. Last PR activity six months ago. Sill worth keeping this open?

@EricCousineau-TRI
Copy link
Contributor Author

Nah, can re-open later when desired. Thanks for the ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants