-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isort: Add configuration file and apply to Python files #13709
isort: Add configuration file and apply to Python files #13709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
bindings/pydrake/doc/gen_sphinx.py, line 11 at r1 (raw file):
import pydrake.all # TODO(eric.cousineau): Make an optional `.all` module.
This comment being duplicated smells like a bug with isort==5.1.2
.
947897b
to
97b0451
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
bindings/pydrake/doc/gen_sphinx.py, line 11 at r1 (raw file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
This comment being duplicated smells like a bug with
isort==5.1.2
.
Fixed! PyCQA/isort#1328 (comment)
97b0451
to
3d5f4d6
Compare
3d5f4d6
to
985cf21
Compare
Last code changes, last July. Last PR activity six months ago. Sill worth keeping this open? |
Nah, can re-open later when desired. Thanks for the ping! |
Towards #13571
Preview of applying isort
This change is