Add python and pip to Dockerfile to support running notebooks on deepnote.com #15586
Conversation
There was a problem hiding this comment.
+@BetsyMcPhail for feature review, please
+@EricCousineau-TRI for platform review, please
Reviewable status: LGTM missing from assignees BetsyMcPhail,EricCousineau-TRI(platform) (waiting on @BetsyMcPhail and @EricCousineau-TRI)
|
Instead of changing which ln -s /usr/bin/python3 /opt/drake/bin/python
ln -s /usr/bin/pip3 /opt/drake/bin/pipI wonder if that's sufficient for deepnote? |
|
Alternatively, if supporting only 20.04 only is okay (why would deepnote need 18.04 in the first place?), then I think just |
|
I'm ok with the 20.04 only solution. I'll need to update my class repos to 20.04, but I've been meaning to do it anyway. |
…n deepnote.com The current images will not run on deepnote. Adding these lines fulfills the requirements, as specified here: https://docs.deepnote.com/environment/custom-environments#custom-image-requirements To reproduce, I have uploaded the revised image to DockerHub as robotlocomotion/drake:pr15586-focal. Visit https://deepnote.com/project/Drake-PR-15586-mPXpOqUZTqe8JBtfj5z4xQ/%2Fnotebook.ipynb . You will need to create an account to proceed, I'm afraid. Then - On the left menu, click on the Environment toolbar, and then look at the "Environment" dropdown. - I've connected 3 docker images: robotlocomotion/drake:bionic and robotlocomotion/drake:focal and robotlocomotion/drake:pr15586-focal - Confirm that selecting the two existing images will spend some time "Loading image..." but then will fail with `We failed to run the image you specified. Your image doesn’t exist, or we don’t have permissions to access it, or it doesn't fulfill the requirements to run.` - Confirm that selecting the revised image will load successfully. - For the revised image, run the first cell of the notebook, and see that pydrake loads successfully and prints the expected file path.
There was a problem hiding this comment.
I've made the updates (including to the commit message) and pushed the new images for testing. @jwnimmer-tri -- do you want to serve as platform, since you've already thought it through? @BetsyMcPhail -- can I get your feature review, please?
For completeness, these
ln -s /usr/bin/python3 /opt/drake/bin/python
ln -s /usr/bin/pip3 /opt/drake/bin/pip
were also sufficient for deepnote, but I've gone with the python-is-python3 spelling as requested.
Reviewable status: LGTM missing from assignees EricCousineau-TRI(platform),BetsyMcPhail (waiting on @BetsyMcPhail and @EricCousineau-TRI)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee BetsyMcPhail (waiting on @BetsyMcPhail)
There was a problem hiding this comment.
-@EricCousineau-TRI for platform
+@jwnimmer-tri for platform, instead.
Reviewable status: LGTM missing from assignee BetsyMcPhail (waiting on @BetsyMcPhail)
|
@RussTedrake If you're happy to just have code review (i.e., I didn't do any manual testing of deepnote as part of my review), then I'd be okay with this PR as single-reviewer. I don't think adding two core ubuntu packages to the image is of any great risk of runtime errors nor developer confusion. |
|
It certainly seems sufficient to me. I think @EricCousineau-TRI might have been taking it for a spin just now. If I don't hear more by this evening, then I'll push it through. |
There was a problem hiding this comment.
Tried to access w/ OAuth via GitHub and Google, but still couldn't access it.
That being said, I think you can merge w/o my review on the notebook / DeepNote workflow for now!
The simplified Docker changes also look great!
-@BetsyMcPhail +@EricCousineau-TRI
Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees jwnimmer-tri(platform),EricCousineau-TRI(platform) (waiting on @RussTedrake)
The current drake docker images will not run on deepnote. Adding these lines fulfills the requirements, as specified here:
https://docs.deepnote.com/environment/custom-environments#custom-image-requirements , and seem a small price to pay for the increased capability.
To reproduce, I have uploaded the revised images to DockerHub as robotlocomotion/drake:pr15586-bionic and robotlocomotion/drake:pr15586-focal. Visit https://deepnote.com/project/Drake-PR-15586-mPXpOqUZTqe8JBtfj5z4xQ/%2Fnotebook.ipynb . You will need to create an account to proceed, I'm afraid. Then
We failed to run the image you specified. Your image doesn’t exist, or we don’t have permissions to access it, or it doesn't fulfill the requirements to run.This change is